You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/01/06 21:17:08 UTC
[GitHub] [incubator-hudi] vinothchandar commented on a change in pull
request #1188: [HUDI-502] provide a custom time zone definition for
TimestampBasedKeyGenerator
vinothchandar commented on a change in pull request #1188: [HUDI-502] provide a custom time zone definition for TimestampBasedKeyGenerator
URL: https://github.com/apache/incubator-hudi/pull/1188#discussion_r363486940
##########
File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/keygen/TimestampBasedKeyGenerator.java
##########
@@ -51,6 +51,8 @@
private final String outputDateFormat;
+ private TimeZone timeZone;
Review comment:
any reason why this is not `final` too?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services