You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@joshua.apache.org by lewis john mcgibbney <le...@apache.org> on 2017/06/28 04:36:27 UTC
Merging 7.X into master??? + cleaning up branches
Hi Folks,
Two things...
1. Currently the branches for Joshua are a bit of a mess... it would be
better if they were named after JIRA issues such that the mappings back to
some concrete development were explicit. Does anyone want to clean these up?
2. Now that 6.1-incubating is released and live, Is there any desire to
merge 7.X branch into master and continue development there? I was not
involved with the 7.X development but it looked like a significant step
forward... it would be a shame for that work to stagnate.
Thanks,
lewis
--
http://home.apache.org/~lewismc/
@hectorMcSpector
http://www.linkedin.com/in/lmcgibbney
Re: Merging 7.X into master??? + cleaning up branches
Posted by Matt Post <po...@cs.jhu.edu>.
Whether to integrate neural stuff in Joshua is an interesting question. The research direction has been to develop fully neural systems that leave behind the phrase-based and hierarchical framework entirely. Doing this in Joshua would basically require a ground-up rewrite and is probably not worth the time. Moses has neural feature functions; for example, you can use a Nematus model as a rescore feature (though it breaks dynamic programming). This might be reasonable to implement as a project but it would be quite a bit of work and introduce GPU requirements that would raise the question of why you'd use Joshua if you had a GPU available. I think that it would be better to focus on low-resource scenarios and user-focused applications, instead.
> On Jun 29, 2017, at 12:35 PM, Tommaso Teofili <to...@gmail.com> wrote:
>
> Hi Matt,
>
> Il giorno gio 29 giu 2017 alle ore 05:21 Matt Post <po...@cs.jhu.edu> ha
> scritto:
>
>> This is definitely a good idea. Many of these branches are dead and are
>> unlikely to contain much that can be merged in, and are therefore probably
>> best deleted. The plan for 7 was a big simplification of much of the guts,
>> but with the transition to neural approaches in the research community,
>> this is unlikely to be done unless it finds a new champion.
>>
>
> do you think we should look at NMT in the Joshua project ?
> Or is it more like you are more interested on NMT at the moment ?
> Or both ? :)
>
> Other than that let's merge 7 to master and drop the remaining stuff,
> except that for the PR for JOSHUA-290 [1] which should be merged into 7
> branch.
>
> Regards,
> Tommaso
>
> [1] : https://github.com/apache/incubator-joshua/pull/71
>
>
>>
>>
>>
>>
>>> On Jun 28, 2017, at 3:43 AM, Tommaso Teofili <to...@gmail.com>
>> wrote:
>>>
>>> +1 for both cleaning up branches *and* merging 7 branch into master.
>>>
>>> Regarding branches and Git let me read through the links and I'll share
>> my
>>> opinion.
>>>
>>> Regards,
>>> Tommaso
>>>
>>> Il giorno mer 28 giu 2017 alle ore 06:41 Chris Mattmann <
>> mattmann@apache.org>
>>> ha scritto:
>>>
>>>> Hey Team,
>>>>
>>>> I recommend that Joshua consider adopting the Tika and/or Nutch
>>>> contribution
>>>> policy RE: branches and Git:
>>>>
>>>> https://github.com/apache/tika/#contributing-via-github
>>>> https://github.com/apache/nutch/#contributing
>>>>
>>>> Cheers,
>>>> Chris
>>>>
>>>>
>>>>
>>>> On 6/27/17, 9:36 PM, "lewis john mcgibbney" <le...@apache.org> wrote:
>>>>
>>>> Hi Folks,
>>>> Two things...
>>>>
>>>> 1. Currently the branches for Joshua are a bit of a mess... it
>>>> would be
>>>> better if they were named after JIRA issues such that the mappings
>>>> back to
>>>> some concrete development were explicit. Does anyone want to clean
>>>> these up?
>>>> 2. Now that 6.1-incubating is released and live, Is there any
>>>> desire to
>>>> merge 7.X branch into master and continue development there? I was
>>>> not
>>>> involved with the 7.X development but it looked like a significant
>>>> step
>>>> forward... it would be a shame for that work to stagnate.
>>>>
>>>> Thanks,
>>>>
>>>> lewis
>>>>
>>>> --
>>>> http://home.apache.org/~lewismc/
>>>> @hectorMcSpector
>>>> http://www.linkedin.com/in/lmcgibbney
>>>>
>>>>
>>>>
>>>>
>>
>>
Re: Merging 7.X into master??? + cleaning up branches
Posted by Tommaso Teofili <to...@gmail.com>.
Hi Matt,
Il giorno gio 29 giu 2017 alle ore 05:21 Matt Post <po...@cs.jhu.edu> ha
scritto:
> This is definitely a good idea. Many of these branches are dead and are
> unlikely to contain much that can be merged in, and are therefore probably
> best deleted. The plan for 7 was a big simplification of much of the guts,
> but with the transition to neural approaches in the research community,
> this is unlikely to be done unless it finds a new champion.
>
do you think we should look at NMT in the Joshua project ?
Or is it more like you are more interested on NMT at the moment ?
Or both ? :)
Other than that let's merge 7 to master and drop the remaining stuff,
except that for the PR for JOSHUA-290 [1] which should be merged into 7
branch.
Regards,
Tommaso
[1] : https://github.com/apache/incubator-joshua/pull/71
>
>
>
>
> > On Jun 28, 2017, at 3:43 AM, Tommaso Teofili <to...@gmail.com>
> wrote:
> >
> > +1 for both cleaning up branches *and* merging 7 branch into master.
> >
> > Regarding branches and Git let me read through the links and I'll share
> my
> > opinion.
> >
> > Regards,
> > Tommaso
> >
> > Il giorno mer 28 giu 2017 alle ore 06:41 Chris Mattmann <
> mattmann@apache.org>
> > ha scritto:
> >
> >> Hey Team,
> >>
> >> I recommend that Joshua consider adopting the Tika and/or Nutch
> >> contribution
> >> policy RE: branches and Git:
> >>
> >> https://github.com/apache/tika/#contributing-via-github
> >> https://github.com/apache/nutch/#contributing
> >>
> >> Cheers,
> >> Chris
> >>
> >>
> >>
> >> On 6/27/17, 9:36 PM, "lewis john mcgibbney" <le...@apache.org> wrote:
> >>
> >> Hi Folks,
> >> Two things...
> >>
> >> 1. Currently the branches for Joshua are a bit of a mess... it
> >> would be
> >> better if they were named after JIRA issues such that the mappings
> >> back to
> >> some concrete development were explicit. Does anyone want to clean
> >> these up?
> >> 2. Now that 6.1-incubating is released and live, Is there any
> >> desire to
> >> merge 7.X branch into master and continue development there? I was
> >> not
> >> involved with the 7.X development but it looked like a significant
> >> step
> >> forward... it would be a shame for that work to stagnate.
> >>
> >> Thanks,
> >>
> >> lewis
> >>
> >> --
> >> http://home.apache.org/~lewismc/
> >> @hectorMcSpector
> >> http://www.linkedin.com/in/lmcgibbney
> >>
> >>
> >>
> >>
>
>
Re: Merging 7.X into master??? + cleaning up branches
Posted by Henry Saputra <he...@gmail.com>.
How about we follow the successful Git branching model way [1] to manage
our branches and releases.
[1] http://nvie.com/posts/a-successful-git-branching-model/
On Wed, Jun 28, 2017 at 8:21 PM, Matt Post <po...@cs.jhu.edu> wrote:
> This is definitely a good idea. Many of these branches are dead and are
> unlikely to contain much that can be merged in, and are therefore probably
> best deleted. The plan for 7 was a big simplification of much of the guts,
> but with the transition to neural approaches in the research community,
> this is unlikely to be done unless it finds a new champion.
>
>
>
>
> > On Jun 28, 2017, at 3:43 AM, Tommaso Teofili <to...@gmail.com>
> wrote:
> >
> > +1 for both cleaning up branches *and* merging 7 branch into master.
> >
> > Regarding branches and Git let me read through the links and I'll share
> my
> > opinion.
> >
> > Regards,
> > Tommaso
> >
> > Il giorno mer 28 giu 2017 alle ore 06:41 Chris Mattmann <
> mattmann@apache.org>
> > ha scritto:
> >
> >> Hey Team,
> >>
> >> I recommend that Joshua consider adopting the Tika and/or Nutch
> >> contribution
> >> policy RE: branches and Git:
> >>
> >> https://github.com/apache/tika/#contributing-via-github
> >> https://github.com/apache/nutch/#contributing
> >>
> >> Cheers,
> >> Chris
> >>
> >>
> >>
> >> On 6/27/17, 9:36 PM, "lewis john mcgibbney" <le...@apache.org> wrote:
> >>
> >> Hi Folks,
> >> Two things...
> >>
> >> 1. Currently the branches for Joshua are a bit of a mess... it
> >> would be
> >> better if they were named after JIRA issues such that the mappings
> >> back to
> >> some concrete development were explicit. Does anyone want to clean
> >> these up?
> >> 2. Now that 6.1-incubating is released and live, Is there any
> >> desire to
> >> merge 7.X branch into master and continue development there? I was
> >> not
> >> involved with the 7.X development but it looked like a significant
> >> step
> >> forward... it would be a shame for that work to stagnate.
> >>
> >> Thanks,
> >>
> >> lewis
> >>
> >> --
> >> http://home.apache.org/~lewismc/
> >> @hectorMcSpector
> >> http://www.linkedin.com/in/lmcgibbney
> >>
> >>
> >>
> >>
>
>
Re: Merging 7.X into master??? + cleaning up branches
Posted by Matt Post <po...@cs.jhu.edu>.
This is definitely a good idea. Many of these branches are dead and are unlikely to contain much that can be merged in, and are therefore probably best deleted. The plan for 7 was a big simplification of much of the guts, but with the transition to neural approaches in the research community, this is unlikely to be done unless it finds a new champion.
> On Jun 28, 2017, at 3:43 AM, Tommaso Teofili <to...@gmail.com> wrote:
>
> +1 for both cleaning up branches *and* merging 7 branch into master.
>
> Regarding branches and Git let me read through the links and I'll share my
> opinion.
>
> Regards,
> Tommaso
>
> Il giorno mer 28 giu 2017 alle ore 06:41 Chris Mattmann <ma...@apache.org>
> ha scritto:
>
>> Hey Team,
>>
>> I recommend that Joshua consider adopting the Tika and/or Nutch
>> contribution
>> policy RE: branches and Git:
>>
>> https://github.com/apache/tika/#contributing-via-github
>> https://github.com/apache/nutch/#contributing
>>
>> Cheers,
>> Chris
>>
>>
>>
>> On 6/27/17, 9:36 PM, "lewis john mcgibbney" <le...@apache.org> wrote:
>>
>> Hi Folks,
>> Two things...
>>
>> 1. Currently the branches for Joshua are a bit of a mess... it
>> would be
>> better if they were named after JIRA issues such that the mappings
>> back to
>> some concrete development were explicit. Does anyone want to clean
>> these up?
>> 2. Now that 6.1-incubating is released and live, Is there any
>> desire to
>> merge 7.X branch into master and continue development there? I was
>> not
>> involved with the 7.X development but it looked like a significant
>> step
>> forward... it would be a shame for that work to stagnate.
>>
>> Thanks,
>>
>> lewis
>>
>> --
>> http://home.apache.org/~lewismc/
>> @hectorMcSpector
>> http://www.linkedin.com/in/lmcgibbney
>>
>>
>>
>>
Re: Merging 7.X into master??? + cleaning up branches
Posted by Tommaso Teofili <to...@gmail.com>.
+1 for both cleaning up branches *and* merging 7 branch into master.
Regarding branches and Git let me read through the links and I'll share my
opinion.
Regards,
Tommaso
Il giorno mer 28 giu 2017 alle ore 06:41 Chris Mattmann <ma...@apache.org>
ha scritto:
> Hey Team,
>
> I recommend that Joshua consider adopting the Tika and/or Nutch
> contribution
> policy RE: branches and Git:
>
> https://github.com/apache/tika/#contributing-via-github
> https://github.com/apache/nutch/#contributing
>
> Cheers,
> Chris
>
>
>
> On 6/27/17, 9:36 PM, "lewis john mcgibbney" <le...@apache.org> wrote:
>
> Hi Folks,
> Two things...
>
> 1. Currently the branches for Joshua are a bit of a mess... it
> would be
> better if they were named after JIRA issues such that the mappings
> back to
> some concrete development were explicit. Does anyone want to clean
> these up?
> 2. Now that 6.1-incubating is released and live, Is there any
> desire to
> merge 7.X branch into master and continue development there? I was
> not
> involved with the 7.X development but it looked like a significant
> step
> forward... it would be a shame for that work to stagnate.
>
> Thanks,
>
> lewis
>
> --
> http://home.apache.org/~lewismc/
> @hectorMcSpector
> http://www.linkedin.com/in/lmcgibbney
>
>
>
>
Re: Merging 7.X into master??? + cleaning up branches
Posted by Chris Mattmann <ma...@apache.org>.
Hey Team,
I recommend that Joshua consider adopting the Tika and/or Nutch contribution
policy RE: branches and Git:
https://github.com/apache/tika/#contributing-via-github
https://github.com/apache/nutch/#contributing
Cheers,
Chris
On 6/27/17, 9:36 PM, "lewis john mcgibbney" <le...@apache.org> wrote:
Hi Folks,
Two things...
1. Currently the branches for Joshua are a bit of a mess... it would be
better if they were named after JIRA issues such that the mappings back to
some concrete development were explicit. Does anyone want to clean these up?
2. Now that 6.1-incubating is released and live, Is there any desire to
merge 7.X branch into master and continue development there? I was not
involved with the 7.X development but it looked like a significant step
forward... it would be a shame for that work to stagnate.
Thanks,
lewis
--
http://home.apache.org/~lewismc/
@hectorMcSpector
http://www.linkedin.com/in/lmcgibbney