You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/01 13:29:46 UTC
[GitHub] [flink] carp84 opened a new pull request #11970: [FLINK-17483][legal] Update flink-sql-connector-elasticsearch7 NOTICE file to correctly reflect bundled dependencies
carp84 opened a new pull request #11970:
URL: https://github.com/apache/flink/pull/11970
## What is the purpose of the change
Fix the legal issue in `flink-sql-connector-elasticsearch7` as reported by FLINK-17483, for master branch
## Brief change log
Update flink-sql-connector-elasticsearch7 NOTICE file to correctly reflect bundled dependencies, including:
* com.carrotsearch:hppc:0.8.1
* com.github.spullara.mustache.java:compiler:0.9.6
* org.elasticsearch:elasticsearch-geo:7.5.1
* org.elasticsearch.plugin:lang-mustache-client:7.5.1
(The same dependencies missing but just with different versions as #11965 )
## Verifying this change
Manually compare the output of shaded plugin and the entries in the NOTICE file, make sure they are in accordance.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] carp84 commented on pull request #11970: [FLINK-17483][legal] Update flink-sql-connector-elasticsearch7 NOTICE file to correctly reflect bundled dependencies
Posted by GitBox <gi...@apache.org>.
carp84 commented on pull request #11970:
URL: https://github.com/apache/flink/pull/11970#issuecomment-623440098
Thanks for the review @zentol , will merge soon.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #11970: [FLINK-17483][legal] Update flink-sql-connector-elasticsearch7 NOTICE file to correctly reflect bundled dependencies
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #11970:
URL: https://github.com/apache/flink/pull/11970#issuecomment-622389283
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 151f32be272c47867647c3ef9877534c37887900 (Fri May 01 13:31:42 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11970: [FLINK-17483][legal] Update flink-sql-connector-elasticsearch7 NOTICE file to correctly reflect bundled dependencies
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11970:
URL: https://github.com/apache/flink/pull/11970#issuecomment-622395974
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "151f32be272c47867647c3ef9877534c37887900",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=518",
"triggerID" : "151f32be272c47867647c3ef9877534c37887900",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 151f32be272c47867647c3ef9877534c37887900 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=518)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #11970: [FLINK-17483][legal] Update flink-sql-connector-elasticsearch7 NOTICE file to correctly reflect bundled dependencies
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #11970:
URL: https://github.com/apache/flink/pull/11970#issuecomment-622395974
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "151f32be272c47867647c3ef9877534c37887900",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "151f32be272c47867647c3ef9877534c37887900",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 151f32be272c47867647c3ef9877534c37887900 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] carp84 commented on pull request #11970: [FLINK-17483][legal] Update flink-sql-connector-elasticsearch7 NOTICE file to correctly reflect bundled dependencies
Posted by GitBox <gi...@apache.org>.
carp84 commented on pull request #11970:
URL: https://github.com/apache/flink/pull/11970#issuecomment-622388870
CC @zentol @rmetzger
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org