You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/06/26 10:20:32 UTC

[GitHub] [rocketmq] sunxi92 opened a new pull request #3090: [#2986]Support for multiple ACL files in a fixed directory

sunxi92 opened a new pull request #3090:
URL: https://github.com/apache/rocketmq/pull/3090


   Support for multiple ACL files in a fixed directory
   #2986


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [rocketmq] sunxi92 commented on pull request #3090: [#2986]Support for multiple ACL files in a fixed directory

Posted by GitBox <gi...@apache.org>.
sunxi92 commented on pull request #3090:
URL: https://github.com/apache/rocketmq/pull/3090#issuecomment-869706859


   @zongtanghu  I don't know if UT has been passed, could you help me confirm it,thx.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [rocketmq] codecov-commenter commented on pull request #3090: [#2986]Support for multiple ACL files in a fixed directory

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #3090:
URL: https://github.com/apache/rocketmq/pull/3090#issuecomment-888916279


   # [Codecov](https://codecov.io/gh/apache/rocketmq/pull/3090?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#3090](https://codecov.io/gh/apache/rocketmq/pull/3090?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2f18991) into [develop](https://codecov.io/gh/apache/rocketmq/commit/6f7b0d6a2daaf4592f44d10608dd57ea1bc79e2f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6f7b0d6) will **increase** coverage by `0.01%`.
   > The diff coverage is `77.39%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/rocketmq/pull/3090/graphs/tree.svg?width=650&height=150&src=pr&token=4w0sxP1wZv&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/rocketmq/pull/3090?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@              Coverage Diff              @@
   ##             develop    #3090      +/-   ##
   =============================================
   + Coverage      47.45%   47.47%   +0.01%     
   - Complexity      4053     4057       +4     
   =============================================
     Files            478      478              
     Lines          32899    32951      +52     
     Branches        4372     4377       +5     
   =============================================
   + Hits           15613    15642      +29     
   - Misses         15256    15276      +20     
   - Partials        2030     2033       +3     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/rocketmq/pull/3090?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...pache/rocketmq/acl/plain/PlainAccessValidator.java](https://codecov.io/gh/apache/rocketmq/pull/3090/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWNsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9hY2wvcGxhaW4vUGxhaW5BY2Nlc3NWYWxpZGF0b3IuamF2YQ==) | `91.04% <0.00%> (-1.27%)` | :arrow_down: |
   | [...g/apache/rocketmq/client/impl/MQClientAPIImpl.java](https://codecov.io/gh/apache/rocketmq/pull/3090/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9NUUNsaWVudEFQSUltcGwuamF2YQ==) | `12.18% <0.00%> (ø)` | |
   | [...mq/common/protocol/body/ClusterAclVersionInfo.java](https://codecov.io/gh/apache/rocketmq/pull/3090/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vcHJvdG9jb2wvYm9keS9DbHVzdGVyQWNsVmVyc2lvbkluZm8uamF2YQ==) | `0.00% <ø> (ø)` | |
   | [...tocol/header/GetBrokerAclConfigResponseHeader.java](https://codecov.io/gh/apache/rocketmq/pull/3090/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vcHJvdG9jb2wvaGVhZGVyL0dldEJyb2tlckFjbENvbmZpZ1Jlc3BvbnNlSGVhZGVyLmphdmE=) | `0.00% <ø> (ø)` | |
   | [...che/rocketmq/acl/plain/PlainPermissionManager.java](https://codecov.io/gh/apache/rocketmq/pull/3090/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWNsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9hY2wvcGxhaW4vUGxhaW5QZXJtaXNzaW9uTWFuYWdlci5qYXZh) | `73.80% <79.46%> (+4.56%)` | :arrow_up: |
   | [...org/apache/rocketmq/store/ha/WaitNotifyObject.java](https://codecov.io/gh/apache/rocketmq/pull/3090/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL2hhL1dhaXROb3RpZnlPYmplY3QuamF2YQ==) | `66.07% <0.00%> (-5.36%)` | :arrow_down: |
   | [...rocketmq/client/impl/factory/MQClientInstance.java](https://codecov.io/gh/apache/rocketmq/pull/3090/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9mYWN0b3J5L01RQ2xpZW50SW5zdGFuY2UuamF2YQ==) | `49.55% <0.00%> (-1.49%)` | :arrow_down: |
   | [...a/org/apache/rocketmq/store/StoreStatsService.java](https://codecov.io/gh/apache/rocketmq/pull/3090/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL1N0b3JlU3RhdHNTZXJ2aWNlLmphdmE=) | `28.85% <0.00%> (-1.32%)` | :arrow_down: |
   | [...ent/impl/consumer/DefaultLitePullConsumerImpl.java](https://codecov.io/gh/apache/rocketmq/pull/3090/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9EZWZhdWx0TGl0ZVB1bGxDb25zdW1lckltcGwuamF2YQ==) | `67.49% <0.00%> (-1.25%)` | :arrow_down: |
   | [...pl/consumer/ConsumeMessageConcurrentlyService.java](https://codecov.io/gh/apache/rocketmq/pull/3090/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9Db25zdW1lTWVzc2FnZUNvbmN1cnJlbnRseVNlcnZpY2UuamF2YQ==) | `47.57% <0.00%> (-0.98%)` | :arrow_down: |
   | ... and [12 more](https://codecov.io/gh/apache/rocketmq/pull/3090/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq/pull/3090?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/rocketmq/pull/3090?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6f7b0d6...2f18991](https://codecov.io/gh/apache/rocketmq/pull/3090?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [rocketmq] sunxi92 edited a comment on pull request #3090: [ISSUE #2986] Support for multiple ACL files in a fixed directory

Posted by GitBox <gi...@apache.org>.
sunxi92 edited a comment on pull request #3090:
URL: https://github.com/apache/rocketmq/pull/3090#issuecomment-996819269


   > @sunxi92 Would you like to resolve conflicts first?
   
   Done! @duhenglucky 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [rocketmq] ShannonDing commented on pull request #3090: [ISSUE #2986] Support for multiple ACL files in a fixed directory

Posted by GitBox <gi...@apache.org>.
ShannonDing commented on pull request #3090:
URL: https://github.com/apache/rocketmq/pull/3090#issuecomment-1014211650


   close due to new PR


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [rocketmq] Aaron-He commented on pull request #3090: [ISSUE #2986] Support for multiple ACL files in a fixed directory

Posted by GitBox <gi...@apache.org>.
Aaron-He commented on pull request #3090:
URL: https://github.com/apache/rocketmq/pull/3090#issuecomment-1012679928


   Good job. But this PR includes too many code style modifications, it will be better to  import the rmq_codeStyle.xml to your IDE


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [rocketmq] duhenglucky commented on pull request #3090: [ISSUE #2986] Support for multiple ACL files in a fixed directory

Posted by GitBox <gi...@apache.org>.
duhenglucky commented on pull request #3090:
URL: https://github.com/apache/rocketmq/pull/3090#issuecomment-1014212340


   new PR:_https://github.com/apache/rocketmq/pull/3761_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [rocketmq] ShannonDing closed pull request #3090: [ISSUE #2986] Support for multiple ACL files in a fixed directory

Posted by GitBox <gi...@apache.org>.
ShannonDing closed pull request #3090:
URL: https://github.com/apache/rocketmq/pull/3090


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [rocketmq] coveralls edited a comment on pull request #3090: [ISSUE #2986] Support for multiple ACL files in a fixed directory

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #3090:
URL: https://github.com/apache/rocketmq/pull/3090#issuecomment-868983772


   
   [![Coverage Status](https://coveralls.io/builds/45094400/badge)](https://coveralls.io/builds/45094400)
   
   Coverage increased (+0.08%) to 56.232% when pulling **d286b48c4a8fa487e772d65ff17fd3704f07149f on sunxi92:acl** into **8cb14687f3946c95092631d9f9d1447024a741de on apache:develop**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [rocketmq] sunxi92 commented on pull request #3090: [ISSUE #2986] Support for multiple ACL files in a fixed directory

Posted by GitBox <gi...@apache.org>.
sunxi92 commented on pull request #3090:
URL: https://github.com/apache/rocketmq/pull/3090#issuecomment-1013287081


   > Good job. But this PR includes too many code style modifications, it will be better to import the rmq_codeStyle.xml to your IDE
   
   I have changed the code style in the new style, the old can be closed.
   The new pr is #3761 @Aaron-He 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [rocketmq] coveralls commented on pull request #3090: [#2986]Support for multiple ACL files in a fixed directory

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #3090:
URL: https://github.com/apache/rocketmq/pull/3090#issuecomment-868983772


   
   [![Coverage Status](https://coveralls.io/builds/40905263/badge)](https://coveralls.io/builds/40905263)
   
   Coverage decreased (-0.2%) to 53.84% when pulling **70c51f10bd706b034b39f9ea8dc740fe2ac7a9a2 on sunxi92:acl** into **df1d93fc8859377b92ba87c6947911281656f355 on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [rocketmq] sunxi92 commented on pull request #3090: [#2986]Support for multiple ACL files in a fixed directory

Posted by GitBox <gi...@apache.org>.
sunxi92 commented on pull request #3090:
URL: https://github.com/apache/rocketmq/pull/3090#issuecomment-869706859


   @zongtanghu  I don't know if UT has been passed, could you help me confirm it,thx.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [rocketmq] sunxi92 removed a comment on pull request #3090: [ISSUE #2986] Support for multiple ACL files in a fixed directory

Posted by GitBox <gi...@apache.org>.
sunxi92 removed a comment on pull request #3090:
URL: https://github.com/apache/rocketmq/pull/3090#issuecomment-996818926


   > conflicts
   Done!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [rocketmq] sunxi92 commented on pull request #3090: [ISSUE #2986] Support for multiple ACL files in a fixed directory

Posted by GitBox <gi...@apache.org>.
sunxi92 commented on pull request #3090:
URL: https://github.com/apache/rocketmq/pull/3090#issuecomment-996819269


   > @sunxi92 Would you like to resolve conflicts first?
   
   Done!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [rocketmq] coveralls edited a comment on pull request #3090: [#2986]Support for multiple ACL files in a fixed directory

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #3090:
URL: https://github.com/apache/rocketmq/pull/3090#issuecomment-868983772


   
   [![Coverage Status](https://coveralls.io/builds/41743466/badge)](https://coveralls.io/builds/41743466)
   
   Coverage increased (+0.01%) to 54.053% when pulling **2f18991b02813049ee506addc51fac1b56dca9d7 on sunxi92:acl** into **6f7b0d6a2daaf4592f44d10608dd57ea1bc79e2f on apache:develop**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [rocketmq] zhangjidi2016 commented on pull request #3090: [#2986]Support for multiple ACL files in a fixed directory

Posted by GitBox <gi...@apache.org>.
zhangjidi2016 commented on pull request #3090:
URL: https://github.com/apache/rocketmq/pull/3090#issuecomment-888889508


   @sunxi92 Please set the target branch to develop


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [rocketmq] sunxi92 commented on pull request #3090: [#2986]Support for multiple ACL files in a fixed directory

Posted by GitBox <gi...@apache.org>.
sunxi92 commented on pull request #3090:
URL: https://github.com/apache/rocketmq/pull/3090#issuecomment-868985201


   please ignore the branch named acl temp


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [rocketmq] sunxi92 commented on pull request #3090: [ISSUE #2986] Support for multiple ACL files in a fixed directory

Posted by GitBox <gi...@apache.org>.
sunxi92 commented on pull request #3090:
URL: https://github.com/apache/rocketmq/pull/3090#issuecomment-996818926


   > conflicts
   Done!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [rocketmq] codecov-commenter edited a comment on pull request #3090: [ISSUE #2986] Support for multiple ACL files in a fixed directory

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #3090:
URL: https://github.com/apache/rocketmq/pull/3090#issuecomment-888916279


   # [Codecov](https://codecov.io/gh/apache/rocketmq/pull/3090?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#3090](https://codecov.io/gh/apache/rocketmq/pull/3090?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d286b48) into [develop](https://codecov.io/gh/apache/rocketmq/commit/8cb14687f3946c95092631d9f9d1447024a741de?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8cb1468) will **increase** coverage by `0.08%`.
   > The diff coverage is `78.26%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/rocketmq/pull/3090/graphs/tree.svg?width=650&height=150&src=pr&token=4w0sxP1wZv&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/rocketmq/pull/3090?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@              Coverage Diff              @@
   ##             develop    #3090      +/-   ##
   =============================================
   + Coverage      49.67%   49.75%   +0.08%     
   - Complexity      4718     4738      +20     
   =============================================
     Files            555      555              
     Lines          36822    36874      +52     
     Branches        4853     4858       +5     
   =============================================
   + Hits           18291    18347      +56     
     Misses         16231    16231              
   + Partials        2300     2296       -4     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/rocketmq/pull/3090?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...pache/rocketmq/acl/plain/PlainAccessValidator.java](https://codecov.io/gh/apache/rocketmq/pull/3090/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWNsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9hY2wvcGxhaW4vUGxhaW5BY2Nlc3NWYWxpZGF0b3IuamF2YQ==) | `91.04% <0.00%> (-1.27%)` | :arrow_down: |
   | [...g/apache/rocketmq/client/impl/MQClientAPIImpl.java](https://codecov.io/gh/apache/rocketmq/pull/3090/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9NUUNsaWVudEFQSUltcGwuamF2YQ==) | `12.87% <0.00%> (ø)` | |
   | [...mq/common/protocol/body/ClusterAclVersionInfo.java](https://codecov.io/gh/apache/rocketmq/pull/3090/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vcHJvdG9jb2wvYm9keS9DbHVzdGVyQWNsVmVyc2lvbkluZm8uamF2YQ==) | `0.00% <ø> (ø)` | |
   | [...tocol/header/GetBrokerAclConfigResponseHeader.java](https://codecov.io/gh/apache/rocketmq/pull/3090/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vcHJvdG9jb2wvaGVhZGVyL0dldEJyb2tlckFjbENvbmZpZ1Jlc3BvbnNlSGVhZGVyLmphdmE=) | `0.00% <ø> (ø)` | |
   | [...che/rocketmq/acl/plain/PlainPermissionManager.java](https://codecov.io/gh/apache/rocketmq/pull/3090/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWNsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9hY2wvcGxhaW4vUGxhaW5QZXJtaXNzaW9uTWFuYWdlci5qYXZh) | `75.91% <80.35%> (+4.03%)` | :arrow_up: |
   | [...rocketmq/broker/filtersrv/FilterServerManager.java](https://codecov.io/gh/apache/rocketmq/pull/3090/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvZmlsdGVyc3J2L0ZpbHRlclNlcnZlck1hbmFnZXIuamF2YQ==) | `20.00% <0.00%> (-14.29%)` | :arrow_down: |
   | [...in/java/org/apache/rocketmq/test/util/MQAdmin.java](https://codecov.io/gh/apache/rocketmq/pull/3090/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvdGVzdC91dGlsL01RQWRtaW4uamF2YQ==) | `38.88% <0.00%> (-5.56%)` | :arrow_down: |
   | [...apache/rocketmq/remoting/netty/ResponseFuture.java](https://codecov.io/gh/apache/rocketmq/pull/3090/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3JlbW90aW5nL25ldHR5L1Jlc3BvbnNlRnV0dXJlLmphdmE=) | `85.00% <0.00%> (-5.00%)` | :arrow_down: |
   | [...rocketmq/remoting/netty/NettyRemotingAbstract.java](https://codecov.io/gh/apache/rocketmq/pull/3090/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3JlbW90aW5nL25ldHR5L05ldHR5UmVtb3RpbmdBYnN0cmFjdC5qYXZh) | `46.88% <0.00%> (-4.03%)` | :arrow_down: |
   | ... and [13 more](https://codecov.io/gh/apache/rocketmq/pull/3090/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq/pull/3090?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/rocketmq/pull/3090?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [8cb1468...d286b48](https://codecov.io/gh/apache/rocketmq/pull/3090?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [rocketmq] duhenglucky commented on pull request #3090: [ISSUE #2986] Support for multiple ACL files in a fixed directory

Posted by GitBox <gi...@apache.org>.
duhenglucky commented on pull request #3090:
URL: https://github.com/apache/rocketmq/pull/3090#issuecomment-996390266


   @sunxi92 Would you like to resolve conflicts first?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org