You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/05/01 13:33:43 UTC
[GitHub] [flink] zoltar9264 opened a new pull request, #19616: [FLINK-26052][docs-zh] Document savepoint format
zoltar9264 opened a new pull request, #19616:
URL: https://github.com/apache/flink/pull/19616
## What is the purpose of the change
Update Chinese documentation regarding FLIP-203
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zoltar9264 commented on a diff in pull request #19616: [FLINK-26052][docs-zh] Document savepoint format
Posted by GitBox <gi...@apache.org>.
zoltar9264 commented on code in PR #19616:
URL: https://github.com/apache/flink/pull/19616#discussion_r866084084
##########
docs/content.zh/docs/ops/state/savepoints.md:
##########
@@ -133,13 +150,15 @@ $ bin/flink savepoint :jobId [:targetDirectory] -yid :yarnAppId
这将触发 ID 为 `:jobId` 和 YARN 应用程序 ID `:yarnAppId` 的作业的 Savepoint，并返回创建的 Savepoint 的路径。
-#### 使用 Savepoint 取消作业
+<a name="stopping-a-job-with-savepoint"></a>
+
+#### 使用 Savepoint 停止作业
```shell
-$ bin/flink cancel -s [:targetDirectory] :jobId
+$ bin/flink stop --type [native/canonical] --savepointPath [:targetDirectory] :jobId
```
-这将自动触发 ID 为 `:jobid` 的作业的 Savepoint，并取消该作业。此外，你可以指定一个目标文件系统目录来存储 Savepoint 。该目录需要能被 JobManager(s) 和 TaskManager(s) 访问。
+这将自动触发 ID 为 `:jobid` 的作业的 Savepoint，并停止该作业。此外，你可以指定一个目标文件系统目录来存储 Savepoint 。该目录需要能被 JobManager(s) 和 TaskManager(s) 访问。你也可以传入创建 Savepoint 的类型。如果没有指定，会采用标准格式创建 Savepoint。
Review Comment:
Thanks @Myasuka , I have committed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #19616: [FLINK-26052][docs-zh] Document savepoint format
Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #19616:
URL: https://github.com/apache/flink/pull/19616#issuecomment-1114241109
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "185d047b7c8f915f09cce5642382b339cf165f19",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "185d047b7c8f915f09cce5642382b339cf165f19",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 185d047b7c8f915f09cce5642382b339cf165f19 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dawidwys commented on pull request #19616: [FLINK-26052][docs-zh] Document savepoint format
Posted by GitBox <gi...@apache.org>.
dawidwys commented on PR #19616:
URL: https://github.com/apache/flink/pull/19616#issuecomment-1114600762
cc @Myasuka @curcur do you mind taking a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zoltar9264 commented on pull request #19616: [FLINK-26052][docs-zh] Document savepoint format
Posted by GitBox <gi...@apache.org>.
zoltar9264 commented on PR #19616:
URL: https://github.com/apache/flink/pull/19616#issuecomment-1119244211
Thanks @Myasuka . Sure, I have done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zoltar9264 commented on pull request #19616: [FLINK-26052][docs-zh] Document savepoint format
Posted by GitBox <gi...@apache.org>.
zoltar9264 commented on PR #19616:
URL: https://github.com/apache/flink/pull/19616#issuecomment-1118132654
> Sorry for missed the part of Stopping a Job with Savepoint, the English doc for this part was added after this issue was created, I didn't notice. I will add it soon.
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Myasuka merged pull request #19616: [FLINK-26052][docs-zh] Document savepoint format
Posted by GitBox <gi...@apache.org>.
Myasuka merged PR #19616:
URL: https://github.com/apache/flink/pull/19616
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Myasuka commented on a diff in pull request #19616: [FLINK-26052][docs-zh] Document savepoint format
Posted by GitBox <gi...@apache.org>.
Myasuka commented on code in PR #19616:
URL: https://github.com/apache/flink/pull/19616#discussion_r865735307
##########
docs/content.zh/docs/ops/state/savepoints.md:
##########
@@ -133,13 +150,15 @@ $ bin/flink savepoint :jobId [:targetDirectory] -yid :yarnAppId
这将触发 ID 为 `:jobId` 和 YARN 应用程序 ID `:yarnAppId` 的作业的 Savepoint，并返回创建的 Savepoint 的路径。
-#### 使用 Savepoint 取消作业
+<a name="stopping-a-job-with-savepoint"></a>
+
+#### 使用 Savepoint 停止作业
```shell
-$ bin/flink cancel -s [:targetDirectory] :jobId
+$ bin/flink stop --type [native/canonical] --savepointPath [:targetDirectory] :jobId
```
-这将自动触发 ID 为 `:jobid` 的作业的 Savepoint，并取消该作业。此外，你可以指定一个目标文件系统目录来存储 Savepoint 。该目录需要能被 JobManager(s) 和 TaskManager(s) 访问。
+这将自动触发 ID 为 `:jobid` 的作业的 Savepoint，并停止该作业。此外，你可以指定一个目标文件系统目录来存储 Savepoint 。该目录需要能被 JobManager(s) 和 TaskManager(s) 访问。你也可以传入创建 Savepoint 的类型。如果没有指定，会采用标准格式创建 Savepoint。
Review Comment:
```suggestion
这将自动触发 ID 为 `:jobid` 的作业的 Savepoint，并停止该作业。此外，你可以指定一个目标文件系统目录来存储 Savepoint 。该目录需要能被 JobManager(s) 和 TaskManager(s) 访问。你也可以指定创建 Savepoint 的格式。如果没有指定，会采用标准格式创建 Savepoint。
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Myasuka commented on a diff in pull request #19616: [FLINK-26052][docs-zh] Document savepoint format
Posted by GitBox <gi...@apache.org>.
Myasuka commented on code in PR #19616:
URL: https://github.com/apache/flink/pull/19616#discussion_r865517671
##########
docs/content.zh/docs/ops/state/savepoints.md:
##########
@@ -116,14 +116,31 @@ mapper-id | State of StatefulMapper
**注意:** 不建议移动或删除正在运行作业的最后一个 Savepoint ，因为这可能会干扰故障恢复。因此，Savepoint 对精确一次的接收器有副作用，为了确保精确一次的语义，如果在最后一个 Savepoint 之后没有 Checkpoint ，那么将使用 Savepoint 进行恢复。
{{< /hint >}}
+<a name="savepoint-format"></a>
+
+#### Savepoint 格式
+
+你可以在 savepoint 的两种二进制格式之间进行选择：
+
+* 规范格式 - 一种在所有 state backends 间统一的格式，允许你使用一种状态后端创建 savepoint 后，使用另一种状态后端还原这个 savepoint。这是最稳定的格式，旨在与之前的版本、模式、修改等保持最大兼容性。
Review Comment:
相比”规范“，可能”标准“一词更准确一些。
##########
docs/content.zh/docs/ops/state/savepoints.md:
##########
@@ -116,14 +116,31 @@ mapper-id | State of StatefulMapper
**注意:** 不建议移动或删除正在运行作业的最后一个 Savepoint ，因为这可能会干扰故障恢复。因此，Savepoint 对精确一次的接收器有副作用，为了确保精确一次的语义，如果在最后一个 Savepoint 之后没有 Checkpoint ，那么将使用 Savepoint 进行恢复。
{{< /hint >}}
+<a name="savepoint-format"></a>
+
+#### Savepoint 格式
+
+你可以在 savepoint 的两种二进制格式之间进行选择：
+
+* 规范格式 - 一种在所有 state backends 间统一的格式，允许你使用一种状态后端创建 savepoint 后，使用另一种状态后端还原这个 savepoint。这是最稳定的格式，旨在与之前的版本、模式、修改等保持最大兼容性。
Review Comment:
`restore`一般翻译成`恢复`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zoltar9264 commented on a diff in pull request #19616: [FLINK-26052][docs-zh] Document savepoint format
Posted by GitBox <gi...@apache.org>.
zoltar9264 commented on code in PR #19616:
URL: https://github.com/apache/flink/pull/19616#discussion_r865524920
##########
docs/content.zh/docs/ops/state/savepoints.md:
##########
@@ -116,14 +116,31 @@ mapper-id | State of StatefulMapper
**注意:** 不建议移动或删除正在运行作业的最后一个 Savepoint ，因为这可能会干扰故障恢复。因此，Savepoint 对精确一次的接收器有副作用，为了确保精确一次的语义，如果在最后一个 Savepoint 之后没有 Checkpoint ，那么将使用 Savepoint 进行恢复。
{{< /hint >}}
+<a name="savepoint-format"></a>
+
+#### Savepoint 格式
+
+你可以在 savepoint 的两种二进制格式之间进行选择：
+
+* 规范格式 - 一种在所有 state backends 间统一的格式，允许你使用一种状态后端创建 savepoint 后，使用另一种状态后端还原这个 savepoint。这是最稳定的格式，旨在与之前的版本、模式、修改等保持最大兼容性。
Review Comment:
Thanks @Myasuka , I have fixed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zoltar9264 commented on pull request #19616: [FLINK-26052][docs-zh] Document savepoint format
Posted by GitBox <gi...@apache.org>.
zoltar9264 commented on PR #19616:
URL: https://github.com/apache/flink/pull/19616#issuecomment-1118125619
Sorry for missed the part of `Stopping a Job with Savepoint`, the English doc for this part was added after this issue was created, I didn't notice. I will add it soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org