You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/09/08 09:15:29 UTC

[GitHub] [pulsar] tisonkun commented on a diff in pull request #17545: [improve][misc] Pull request template

tisonkun commented on code in PR #17545:
URL: https://github.com/apache/pulsar/pull/17545#discussion_r965709301


##########
.github/PULL_REQUEST_TEMPLATE.md:
##########
@@ -10,26 +10,23 @@
   - Each commit in the pull request has a meaningful commit message
 
   - Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
-
-**(The sections below can be removed for hotfixes of typos)**

Review Comment:
   This is not true. We should retain the documentation section since it's read by actions. Also, I tend not to open the door for "hotfixes". If the change is trivial, taking some time to go through the template doesn't hurt, as long as the template is concise.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org