You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by bhavik patel <bh...@gmail.com> on 2017/05/17 11:05:20 UTC
Review Request 59335: RANGER-1583 : Test connections are failing for
plugins after upgrade
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59335/
-----------------------------------------------------------
Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
Bugs: RANGER-1583
https://issues.apache.org/jira/browse/RANGER-1583
Repository: ranger
Description
-------
After upgrade from ranger-0.6 to ranger-0.7 all test connections are failing for plugins.
Below error is shown in xa_portal.log:
ERROR org.apache.ranger.plugin.util.PasswordUtils (PasswordUtils.java:129) - Unable to decrypt password due to error
Diffs
-----
agents-common/src/main/java/org/apache/ranger/plugin/util/PasswordUtils.java 3759b8d
security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java a44aa46
security-admin/src/main/resources/conf.dist/ranger-admin-default-site.xml 4f5f1d3
Diff: https://reviews.apache.org/r/59335/diff/1/
Testing
-------
1. After upgrade from ranger-0.6 to ranger-0.7 verified plugins test-connections & resource-lookup.
Thanks,
bhavik patel
Re: Review Request 59335: RANGER-1583 : Test connections are failing
for plugins after upgrade
Posted by Gautam Borad <gb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59335/#review175525
-----------------------------------------------------------
Ship it!
Ship It!
- Gautam Borad
On May 19, 2017, 1:33 p.m., bhavik patel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59335/
> -----------------------------------------------------------
>
> (Updated May 19, 2017, 1:33 p.m.)
>
>
> Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1583
> https://issues.apache.org/jira/browse/RANGER-1583
>
>
> Repository: ranger
>
>
> Description
> -------
>
> After upgrade from ranger-0.6 to ranger-0.7 all test connections are failing for plugins.
> Below error is shown in xa_portal.log:
> ERROR org.apache.ranger.plugin.util.PasswordUtils (PasswordUtils.java:129) - Unable to decrypt password due to error
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/util/PasswordUtils.java 3759b8d
> security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java a44aa46
> security-admin/src/main/java/org/apache/ranger/service/RangerServiceService.java 256d42e
> security-admin/src/main/resources/conf.dist/ranger-admin-default-site.xml 4f5f1d3
>
>
> Diff: https://reviews.apache.org/r/59335/diff/2/
>
>
> Testing
> -------
>
> 1. After upgrade from ranger-0.6 to ranger-0.7 verified plugins test-connections & resource-lookup.
>
>
> Thanks,
>
> bhavik patel
>
>
Re: Review Request 59335: RANGER-1583 : Test connections are failing
for plugins after upgrade
Posted by Colm O hEigeartaigh <co...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59335/#review175523
-----------------------------------------------------------
Ship it!
Ship It!
- Colm O hEigeartaigh
On May 19, 2017, 1:33 p.m., bhavik patel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59335/
> -----------------------------------------------------------
>
> (Updated May 19, 2017, 1:33 p.m.)
>
>
> Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1583
> https://issues.apache.org/jira/browse/RANGER-1583
>
>
> Repository: ranger
>
>
> Description
> -------
>
> After upgrade from ranger-0.6 to ranger-0.7 all test connections are failing for plugins.
> Below error is shown in xa_portal.log:
> ERROR org.apache.ranger.plugin.util.PasswordUtils (PasswordUtils.java:129) - Unable to decrypt password due to error
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/util/PasswordUtils.java 3759b8d
> security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java a44aa46
> security-admin/src/main/java/org/apache/ranger/service/RangerServiceService.java 256d42e
> security-admin/src/main/resources/conf.dist/ranger-admin-default-site.xml 4f5f1d3
>
>
> Diff: https://reviews.apache.org/r/59335/diff/2/
>
>
> Testing
> -------
>
> 1. After upgrade from ranger-0.6 to ranger-0.7 verified plugins test-connections & resource-lookup.
>
>
> Thanks,
>
> bhavik patel
>
>
Re: Review Request 59335: RANGER-1583 : Test connections are failing
for plugins after upgrade
Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
> On May 19, 2017, 3:24 p.m., Velmurugan Periasamy wrote:
> > Ship It!
>
> Colm O hEigeartaigh wrote:
> Are the concerns I raised above addressed in the latest patch?
yes Colm, I see they are addressed.
- Velmurugan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59335/#review175508
-----------------------------------------------------------
On May 19, 2017, 1:33 p.m., bhavik patel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59335/
> -----------------------------------------------------------
>
> (Updated May 19, 2017, 1:33 p.m.)
>
>
> Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1583
> https://issues.apache.org/jira/browse/RANGER-1583
>
>
> Repository: ranger
>
>
> Description
> -------
>
> After upgrade from ranger-0.6 to ranger-0.7 all test connections are failing for plugins.
> Below error is shown in xa_portal.log:
> ERROR org.apache.ranger.plugin.util.PasswordUtils (PasswordUtils.java:129) - Unable to decrypt password due to error
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/util/PasswordUtils.java 3759b8d
> security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java a44aa46
> security-admin/src/main/java/org/apache/ranger/service/RangerServiceService.java 256d42e
> security-admin/src/main/resources/conf.dist/ranger-admin-default-site.xml 4f5f1d3
>
>
> Diff: https://reviews.apache.org/r/59335/diff/2/
>
>
> Testing
> -------
>
> 1. After upgrade from ranger-0.6 to ranger-0.7 verified plugins test-connections & resource-lookup.
>
>
> Thanks,
>
> bhavik patel
>
>
Re: Review Request 59335: RANGER-1583 : Test connections are failing
for plugins after upgrade
Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
> On May 19, 2017, 3:24 p.m., Velmurugan Periasamy wrote:
> > Ship It!
>
> Colm O hEigeartaigh wrote:
> Are the concerns I raised above addressed in the latest patch?
>
> Velmurugan Periasamy wrote:
> yes Colm, I see they are addressed.
>
> Colm O hEigeartaigh wrote:
> Hi Vel, I still see a default iteration count of "17", or am I missing something?
>
> Velmurugan Periasamy wrote:
> I see code in setPropertiesValue to use DEFAULT_ITERATION_COUNT only for old installs. For the new installs, can't the user change the iteration count?
>
> Colm O hEigeartaigh wrote:
> Ah ok. So if I understand correctly, then the value of "1000" in "ranger-admin-default-site.xml" is used for new deployments, but for old deployments then it falls back to "17"?
yes, that is my understanding as well.
- Velmurugan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59335/#review175508
-----------------------------------------------------------
On May 19, 2017, 1:33 p.m., bhavik patel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59335/
> -----------------------------------------------------------
>
> (Updated May 19, 2017, 1:33 p.m.)
>
>
> Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1583
> https://issues.apache.org/jira/browse/RANGER-1583
>
>
> Repository: ranger
>
>
> Description
> -------
>
> After upgrade from ranger-0.6 to ranger-0.7 all test connections are failing for plugins.
> Below error is shown in xa_portal.log:
> ERROR org.apache.ranger.plugin.util.PasswordUtils (PasswordUtils.java:129) - Unable to decrypt password due to error
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/util/PasswordUtils.java 3759b8d
> security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java a44aa46
> security-admin/src/main/java/org/apache/ranger/service/RangerServiceService.java 256d42e
> security-admin/src/main/resources/conf.dist/ranger-admin-default-site.xml 4f5f1d3
>
>
> Diff: https://reviews.apache.org/r/59335/diff/2/
>
>
> Testing
> -------
>
> 1. After upgrade from ranger-0.6 to ranger-0.7 verified plugins test-connections & resource-lookup.
>
>
> Thanks,
>
> bhavik patel
>
>
Re: Review Request 59335: RANGER-1583 : Test connections are failing
for plugins after upgrade
Posted by Colm O hEigeartaigh <co...@apache.org>.
> On May 19, 2017, 3:24 p.m., Velmurugan Periasamy wrote:
> > Ship It!
Are the concerns I raised above addressed in the latest patch?
- Colm
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59335/#review175508
-----------------------------------------------------------
On May 19, 2017, 1:33 p.m., bhavik patel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59335/
> -----------------------------------------------------------
>
> (Updated May 19, 2017, 1:33 p.m.)
>
>
> Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1583
> https://issues.apache.org/jira/browse/RANGER-1583
>
>
> Repository: ranger
>
>
> Description
> -------
>
> After upgrade from ranger-0.6 to ranger-0.7 all test connections are failing for plugins.
> Below error is shown in xa_portal.log:
> ERROR org.apache.ranger.plugin.util.PasswordUtils (PasswordUtils.java:129) - Unable to decrypt password due to error
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/util/PasswordUtils.java 3759b8d
> security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java a44aa46
> security-admin/src/main/java/org/apache/ranger/service/RangerServiceService.java 256d42e
> security-admin/src/main/resources/conf.dist/ranger-admin-default-site.xml 4f5f1d3
>
>
> Diff: https://reviews.apache.org/r/59335/diff/2/
>
>
> Testing
> -------
>
> 1. After upgrade from ranger-0.6 to ranger-0.7 verified plugins test-connections & resource-lookup.
>
>
> Thanks,
>
> bhavik patel
>
>
Re: Review Request 59335: RANGER-1583 : Test connections are failing
for plugins after upgrade
Posted by Colm O hEigeartaigh <co...@apache.org>.
> On May 19, 2017, 3:24 p.m., Velmurugan Periasamy wrote:
> > Ship It!
>
> Colm O hEigeartaigh wrote:
> Are the concerns I raised above addressed in the latest patch?
>
> Velmurugan Periasamy wrote:
> yes Colm, I see they are addressed.
Hi Vel, I still see a default iteration count of "17", or am I missing something?
- Colm
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59335/#review175508
-----------------------------------------------------------
On May 19, 2017, 1:33 p.m., bhavik patel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59335/
> -----------------------------------------------------------
>
> (Updated May 19, 2017, 1:33 p.m.)
>
>
> Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1583
> https://issues.apache.org/jira/browse/RANGER-1583
>
>
> Repository: ranger
>
>
> Description
> -------
>
> After upgrade from ranger-0.6 to ranger-0.7 all test connections are failing for plugins.
> Below error is shown in xa_portal.log:
> ERROR org.apache.ranger.plugin.util.PasswordUtils (PasswordUtils.java:129) - Unable to decrypt password due to error
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/util/PasswordUtils.java 3759b8d
> security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java a44aa46
> security-admin/src/main/java/org/apache/ranger/service/RangerServiceService.java 256d42e
> security-admin/src/main/resources/conf.dist/ranger-admin-default-site.xml 4f5f1d3
>
>
> Diff: https://reviews.apache.org/r/59335/diff/2/
>
>
> Testing
> -------
>
> 1. After upgrade from ranger-0.6 to ranger-0.7 verified plugins test-connections & resource-lookup.
>
>
> Thanks,
>
> bhavik patel
>
>
Re: Review Request 59335: RANGER-1583 : Test connections are failing
for plugins after upgrade
Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
> On May 19, 2017, 3:24 p.m., Velmurugan Periasamy wrote:
> > Ship It!
>
> Colm O hEigeartaigh wrote:
> Are the concerns I raised above addressed in the latest patch?
>
> Velmurugan Periasamy wrote:
> yes Colm, I see they are addressed.
>
> Colm O hEigeartaigh wrote:
> Hi Vel, I still see a default iteration count of "17", or am I missing something?
I see code in setPropertiesValue to use DEFAULT_ITERATION_COUNT only for old installs. For the new installs, can't the user change the iteration count?
- Velmurugan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59335/#review175508
-----------------------------------------------------------
On May 19, 2017, 1:33 p.m., bhavik patel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59335/
> -----------------------------------------------------------
>
> (Updated May 19, 2017, 1:33 p.m.)
>
>
> Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1583
> https://issues.apache.org/jira/browse/RANGER-1583
>
>
> Repository: ranger
>
>
> Description
> -------
>
> After upgrade from ranger-0.6 to ranger-0.7 all test connections are failing for plugins.
> Below error is shown in xa_portal.log:
> ERROR org.apache.ranger.plugin.util.PasswordUtils (PasswordUtils.java:129) - Unable to decrypt password due to error
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/util/PasswordUtils.java 3759b8d
> security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java a44aa46
> security-admin/src/main/java/org/apache/ranger/service/RangerServiceService.java 256d42e
> security-admin/src/main/resources/conf.dist/ranger-admin-default-site.xml 4f5f1d3
>
>
> Diff: https://reviews.apache.org/r/59335/diff/2/
>
>
> Testing
> -------
>
> 1. After upgrade from ranger-0.6 to ranger-0.7 verified plugins test-connections & resource-lookup.
>
>
> Thanks,
>
> bhavik patel
>
>
Re: Review Request 59335: RANGER-1583 : Test connections are failing
for plugins after upgrade
Posted by Colm O hEigeartaigh <co...@apache.org>.
> On May 19, 2017, 3:24 p.m., Velmurugan Periasamy wrote:
> > Ship It!
>
> Colm O hEigeartaigh wrote:
> Are the concerns I raised above addressed in the latest patch?
>
> Velmurugan Periasamy wrote:
> yes Colm, I see they are addressed.
>
> Colm O hEigeartaigh wrote:
> Hi Vel, I still see a default iteration count of "17", or am I missing something?
>
> Velmurugan Periasamy wrote:
> I see code in setPropertiesValue to use DEFAULT_ITERATION_COUNT only for old installs. For the new installs, can't the user change the iteration count?
Ah ok. So if I understand correctly, then the value of "1000" in "ranger-admin-default-site.xml" is used for new deployments, but for old deployments then it falls back to "17"?
- Colm
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59335/#review175508
-----------------------------------------------------------
On May 19, 2017, 1:33 p.m., bhavik patel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59335/
> -----------------------------------------------------------
>
> (Updated May 19, 2017, 1:33 p.m.)
>
>
> Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1583
> https://issues.apache.org/jira/browse/RANGER-1583
>
>
> Repository: ranger
>
>
> Description
> -------
>
> After upgrade from ranger-0.6 to ranger-0.7 all test connections are failing for plugins.
> Below error is shown in xa_portal.log:
> ERROR org.apache.ranger.plugin.util.PasswordUtils (PasswordUtils.java:129) - Unable to decrypt password due to error
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/util/PasswordUtils.java 3759b8d
> security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java a44aa46
> security-admin/src/main/java/org/apache/ranger/service/RangerServiceService.java 256d42e
> security-admin/src/main/resources/conf.dist/ranger-admin-default-site.xml 4f5f1d3
>
>
> Diff: https://reviews.apache.org/r/59335/diff/2/
>
>
> Testing
> -------
>
> 1. After upgrade from ranger-0.6 to ranger-0.7 verified plugins test-connections & resource-lookup.
>
>
> Thanks,
>
> bhavik patel
>
>
Re: Review Request 59335: RANGER-1583 : Test connections are failing
for plugins after upgrade
Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59335/#review175508
-----------------------------------------------------------
Ship it!
Ship It!
- Velmurugan Periasamy
On May 19, 2017, 1:33 p.m., bhavik patel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59335/
> -----------------------------------------------------------
>
> (Updated May 19, 2017, 1:33 p.m.)
>
>
> Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1583
> https://issues.apache.org/jira/browse/RANGER-1583
>
>
> Repository: ranger
>
>
> Description
> -------
>
> After upgrade from ranger-0.6 to ranger-0.7 all test connections are failing for plugins.
> Below error is shown in xa_portal.log:
> ERROR org.apache.ranger.plugin.util.PasswordUtils (PasswordUtils.java:129) - Unable to decrypt password due to error
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/util/PasswordUtils.java 3759b8d
> security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java a44aa46
> security-admin/src/main/java/org/apache/ranger/service/RangerServiceService.java 256d42e
> security-admin/src/main/resources/conf.dist/ranger-admin-default-site.xml 4f5f1d3
>
>
> Diff: https://reviews.apache.org/r/59335/diff/2/
>
>
> Testing
> -------
>
> 1. After upgrade from ranger-0.6 to ranger-0.7 verified plugins test-connections & resource-lookup.
>
>
> Thanks,
>
> bhavik patel
>
>
Re: Review Request 59335: RANGER-1583 : Test connections are failing
for plugins after upgrade
Posted by bhavik patel <bh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59335/
-----------------------------------------------------------
(Updated May 19, 2017, 1:33 p.m.)
Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
Bugs: RANGER-1583
https://issues.apache.org/jira/browse/RANGER-1583
Repository: ranger
Description
-------
After upgrade from ranger-0.6 to ranger-0.7 all test connections are failing for plugins.
Below error is shown in xa_portal.log:
ERROR org.apache.ranger.plugin.util.PasswordUtils (PasswordUtils.java:129) - Unable to decrypt password due to error
Diffs (updated)
-----
agents-common/src/main/java/org/apache/ranger/plugin/util/PasswordUtils.java 3759b8d
security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java a44aa46
security-admin/src/main/java/org/apache/ranger/service/RangerServiceService.java 256d42e
security-admin/src/main/resources/conf.dist/ranger-admin-default-site.xml 4f5f1d3
Diff: https://reviews.apache.org/r/59335/diff/2/
Changes: https://reviews.apache.org/r/59335/diff/1-2/
Testing
-------
1. After upgrade from ranger-0.6 to ranger-0.7 verified plugins test-connections & resource-lookup.
Thanks,
bhavik patel
Re: Review Request 59335: RANGER-1583 : Test connections are failing
for plugins after upgrade
Posted by bhavik patel <bh...@gmail.com>.
> On May 17, 2017, 11:12 a.m., Colm O hEigeartaigh wrote:
> > Why is the iteration count now "17"?
>
> bhavik patel wrote:
> For previous version this iteration count was 17 so to support backwards compatibility we have kept this count as 17, once the upgrade is successful the user can change the value in xml file.
> For fresh install whatever the user want they can configure accordingly.
>
> Colm O hEigeartaigh wrote:
> OK thanks. For a new major release like 1.0.0 though, would it not be better to default to "1000" and any user who is upgrading can change it to "17"?
Yes, user can do that but if we set default to "1000" then test connection & resource-lookup will not work for old repo's those created in minor version; so we have set it to "17".
- bhavik
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59335/#review175228
-----------------------------------------------------------
On May 17, 2017, 11:05 a.m., bhavik patel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59335/
> -----------------------------------------------------------
>
> (Updated May 17, 2017, 11:05 a.m.)
>
>
> Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1583
> https://issues.apache.org/jira/browse/RANGER-1583
>
>
> Repository: ranger
>
>
> Description
> -------
>
> After upgrade from ranger-0.6 to ranger-0.7 all test connections are failing for plugins.
> Below error is shown in xa_portal.log:
> ERROR org.apache.ranger.plugin.util.PasswordUtils (PasswordUtils.java:129) - Unable to decrypt password due to error
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/util/PasswordUtils.java 3759b8d
> security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java a44aa46
> security-admin/src/main/resources/conf.dist/ranger-admin-default-site.xml 4f5f1d3
>
>
> Diff: https://reviews.apache.org/r/59335/diff/1/
>
>
> Testing
> -------
>
> 1. After upgrade from ranger-0.6 to ranger-0.7 verified plugins test-connections & resource-lookup.
>
>
> Thanks,
>
> bhavik patel
>
>
Re: Review Request 59335: RANGER-1583 : Test connections are failing
for plugins after upgrade
Posted by Colm O hEigeartaigh <co...@apache.org>.
> On May 17, 2017, 11:12 a.m., Colm O hEigeartaigh wrote:
> > Why is the iteration count now "17"?
>
> bhavik patel wrote:
> For previous version this iteration count was 17 so to support backwards compatibility we have kept this count as 17, once the upgrade is successful the user can change the value in xml file.
> For fresh install whatever the user want they can configure accordingly.
>
> Colm O hEigeartaigh wrote:
> OK thanks. For a new major release like 1.0.0 though, would it not be better to default to "1000" and any user who is upgrading can change it to "17"?
>
> bhavik patel wrote:
> Yes, user can do that but if we set default to "1000" then test connection & resource-lookup will not work for old repo's those created in minor version; so we have set it to "17".
Yes understood, let me rephrase a bit though: "is having to change a config value for backwards compatibility in a new major release worse than forever having an insecure default value of 17 for new installs"? From a security POV we should always aim to be "secure by default".
- Colm
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59335/#review175228
-----------------------------------------------------------
On May 17, 2017, 11:05 a.m., bhavik patel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59335/
> -----------------------------------------------------------
>
> (Updated May 17, 2017, 11:05 a.m.)
>
>
> Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1583
> https://issues.apache.org/jira/browse/RANGER-1583
>
>
> Repository: ranger
>
>
> Description
> -------
>
> After upgrade from ranger-0.6 to ranger-0.7 all test connections are failing for plugins.
> Below error is shown in xa_portal.log:
> ERROR org.apache.ranger.plugin.util.PasswordUtils (PasswordUtils.java:129) - Unable to decrypt password due to error
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/util/PasswordUtils.java 3759b8d
> security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java a44aa46
> security-admin/src/main/resources/conf.dist/ranger-admin-default-site.xml 4f5f1d3
>
>
> Diff: https://reviews.apache.org/r/59335/diff/1/
>
>
> Testing
> -------
>
> 1. After upgrade from ranger-0.6 to ranger-0.7 verified plugins test-connections & resource-lookup.
>
>
> Thanks,
>
> bhavik patel
>
>
Re: Review Request 59335: RANGER-1583 : Test connections are failing
for plugins after upgrade
Posted by Colm O hEigeartaigh <co...@apache.org>.
> On May 17, 2017, 11:12 a.m., Colm O hEigeartaigh wrote:
> > Why is the iteration count now "17"?
>
> bhavik patel wrote:
> For previous version this iteration count was 17 so to support backwards compatibility we have kept this count as 17, once the upgrade is successful the user can change the value in xml file.
> For fresh install whatever the user want they can configure accordingly.
OK thanks. For a new major release like 1.0.0 though, would it not be better to default to "1000" and any user who is upgrading can change it to "17"?
- Colm
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59335/#review175228
-----------------------------------------------------------
On May 17, 2017, 11:05 a.m., bhavik patel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59335/
> -----------------------------------------------------------
>
> (Updated May 17, 2017, 11:05 a.m.)
>
>
> Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1583
> https://issues.apache.org/jira/browse/RANGER-1583
>
>
> Repository: ranger
>
>
> Description
> -------
>
> After upgrade from ranger-0.6 to ranger-0.7 all test connections are failing for plugins.
> Below error is shown in xa_portal.log:
> ERROR org.apache.ranger.plugin.util.PasswordUtils (PasswordUtils.java:129) - Unable to decrypt password due to error
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/util/PasswordUtils.java 3759b8d
> security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java a44aa46
> security-admin/src/main/resources/conf.dist/ranger-admin-default-site.xml 4f5f1d3
>
>
> Diff: https://reviews.apache.org/r/59335/diff/1/
>
>
> Testing
> -------
>
> 1. After upgrade from ranger-0.6 to ranger-0.7 verified plugins test-connections & resource-lookup.
>
>
> Thanks,
>
> bhavik patel
>
>
Re: Review Request 59335: RANGER-1583 : Test connections are failing
for plugins after upgrade
Posted by bhavik patel <bh...@gmail.com>.
> On May 17, 2017, 11:12 a.m., Colm O hEigeartaigh wrote:
> > Why is the iteration count now "17"?
For previous version this iteration count was 17 so to support backwards compatibility we have kept this count as 17, once the upgrade is successful the user can change the value in xml file.
For fresh install whatever the user want they can configure accordingly.
- bhavik
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59335/#review175228
-----------------------------------------------------------
On May 17, 2017, 11:05 a.m., bhavik patel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59335/
> -----------------------------------------------------------
>
> (Updated May 17, 2017, 11:05 a.m.)
>
>
> Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1583
> https://issues.apache.org/jira/browse/RANGER-1583
>
>
> Repository: ranger
>
>
> Description
> -------
>
> After upgrade from ranger-0.6 to ranger-0.7 all test connections are failing for plugins.
> Below error is shown in xa_portal.log:
> ERROR org.apache.ranger.plugin.util.PasswordUtils (PasswordUtils.java:129) - Unable to decrypt password due to error
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/util/PasswordUtils.java 3759b8d
> security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java a44aa46
> security-admin/src/main/resources/conf.dist/ranger-admin-default-site.xml 4f5f1d3
>
>
> Diff: https://reviews.apache.org/r/59335/diff/1/
>
>
> Testing
> -------
>
> 1. After upgrade from ranger-0.6 to ranger-0.7 verified plugins test-connections & resource-lookup.
>
>
> Thanks,
>
> bhavik patel
>
>
Re: Review Request 59335: RANGER-1583 : Test connections are failing
for plugins after upgrade
Posted by Colm O hEigeartaigh <co...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59335/#review175228
-----------------------------------------------------------
Why is the iteration count now "17"?
- Colm O hEigeartaigh
On May 17, 2017, 11:05 a.m., bhavik patel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59335/
> -----------------------------------------------------------
>
> (Updated May 17, 2017, 11:05 a.m.)
>
>
> Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1583
> https://issues.apache.org/jira/browse/RANGER-1583
>
>
> Repository: ranger
>
>
> Description
> -------
>
> After upgrade from ranger-0.6 to ranger-0.7 all test connections are failing for plugins.
> Below error is shown in xa_portal.log:
> ERROR org.apache.ranger.plugin.util.PasswordUtils (PasswordUtils.java:129) - Unable to decrypt password due to error
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/util/PasswordUtils.java 3759b8d
> security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java a44aa46
> security-admin/src/main/resources/conf.dist/ranger-admin-default-site.xml 4f5f1d3
>
>
> Diff: https://reviews.apache.org/r/59335/diff/1/
>
>
> Testing
> -------
>
> 1. After upgrade from ranger-0.6 to ranger-0.7 verified plugins test-connections & resource-lookup.
>
>
> Thanks,
>
> bhavik patel
>
>