You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2019/10/18 19:06:32 UTC

[GitHub] [mynewt-core] agross-korg commented on a change in pull request #2056: dialog_dk1469x-dk-pro: Fix otp_write_key

agross-korg commented on a change in pull request #2056: dialog_dk1469x-dk-pro: Fix otp_write_key
URL: https://github.com/apache/mynewt-core/pull/2056#discussion_r336636364
 
 

 ##########
 File path: hw/bsp/dialog_da1469x-dk-pro/otp_tool.py
 ##########
 @@ -179,9 +180,9 @@ def otp_write_key(infile, index, segment, uart):
             else:
                 # read key from base64 encoded AES key file
                 buf = f.read()
-                if isBase64(buf):
-                    if len(buf) != 32:
-                        raise SystemExit("AES key file has incorrect length")
+                buf = base64.b64decode(buf)
 
 Review comment:
   yes
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services