You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-issues@jackrabbit.apache.org by "Stefan Egli (Jira)" <ji...@apache.org> on 2024/11/06 11:17:00 UTC
[jira] [Resolved] (OAK-11251) Improve warning in collectFullGC
[ https://issues.apache.org/jira/browse/OAK-11251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stefan Egli resolved OAK-11251.
-------------------------------
Resolution: Done
Marking done, [PR|https://github.com/apache/jackrabbit-oak/pull/1844] is merged, and we should have a clean plate for the release
> Improve warning in collectFullGC
> --------------------------------
>
> Key: OAK-11251
> URL: https://issues.apache.org/jira/browse/OAK-11251
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: documentmk
> Reporter: José Andrés Cordero Benítez
> Assignee: José Andrés Cordero Benítez
> Priority: Minor
> Labels: DetailedGC
>
> This warning could be improved: [https://github.com/apache/jackrabbit-oak/blob/trunk/oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollector.java#L941]
> For some reason that is still unclear to me, it seems to log the warning for all documents traversed. Example on a test repository:
> {code:java}
> [sling-oak-2-org.apache.jackrabbit.oak.plugins.document.DocumentNodeStoreService$RevisionGCJob] org.apache.jackrabbit.oak.plugins.document.VersionGarbageCollector collectFullGC : document has older _modified than query boundary : 1730593015 (from: 1730593015001 [2024-11-03 00:16:55.001], to: 1730593020000 [2024-11-03 00:17:00.000]) {code}
> Both _modified and boundaries are converted to milliseconds during comparison, but in this example _modified has a value of 1730593015000 (in ms) and the lower boundary 1730593015001. {*}There is one extra millisecond in the from boundary{*}, making the warning to be logged in all the cases.
> I still don't know where and why that extra millisecond is added, but since Oak 1.72 should have FullGC ready, I think this warning should be improved.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)