You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/10/06 16:52:54 UTC

[GitHub] [spark] srowen commented on pull request #34175: [SPARK-36929][SQL] Remove Unused Method EliminateSubqueryAliasesSuite#assertEquivalent

srowen commented on pull request #34175:
URL: https://github.com/apache/spark/pull/34175#issuecomment-936676325


   Yes, this looks unused. There are several other copies of this method, which are used. I wonder if, while you're here, you can see if it makes sense to move some other copies of the method into one super-class method that's reused? not sure if it's possible.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org