You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/08/22 11:00:23 UTC
[GitHub] [airflow] ephraimbuddy opened a new pull request, #25869: Fix typo that crashes migration upgrade
ephraimbuddy opened a new pull request, #25869:
URL: https://github.com/apache/airflow/pull/25869
This typo was not detected because we now create new db from the ORM and CI
runs on clean DB for a start.
I have added a db reset/upgrade/downgrade test to detect this behaviour going forward
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ephraimbuddy commented on pull request #25869: Fix migration issues and tighten the CI upgrade/downgrade test
Posted by GitBox <gi...@apache.org>.
ephraimbuddy commented on PR #25869:
URL: https://github.com/apache/airflow/pull/25869#issuecomment-1223311963
> Should be fixed now. please rebase @ephraimbuddy :)
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #25869: Fix migration issues and tighten the CI upgrade/downgrade test
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #25869:
URL: https://github.com/apache/airflow/pull/25869#issuecomment-1223152507
> It looks like the failing tests are not caused by the PR. Have rerun it before and rebased but it keeps failing cc: @potiuk
The PRs that are changing "build" scripts running in "upgrade to newer deps" mode. The "warnings" issues (caused by new urrllib3 should be handled by https://github.com/apache/airflow/pull/25885 (please approve). I am not sure what PRod image failure is about (lookign into it).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ephraimbuddy commented on a diff in pull request #25869: Fix migration issues and tighten the CI upgrade/downgrade test
Posted by GitBox <gi...@apache.org>.
ephraimbuddy commented on code in PR #25869:
URL: https://github.com/apache/airflow/pull/25869#discussion_r951853689
##########
airflow/migrations/versions/0113_2_4_0_compare_types_between_orm_and_db.py:
##########
@@ -163,6 +163,15 @@ def downgrade():
batch_op.alter_column(
'created_at', existing_type=TIMESTAMP(), type_=sa.DateTime(), existing_nullable=False
)
+ with op.batch_alter_table('serialized_dag', schema=None) as batch_op:
+ # drop server_default
Review Comment:
```suggestion
# add server_default
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ephraimbuddy commented on pull request #25869: Fix migration issues and tighten the CI upgrade/downgrade test
Posted by GitBox <gi...@apache.org>.
ephraimbuddy commented on PR #25869:
URL: https://github.com/apache/airflow/pull/25869#issuecomment-1223143507
It looks like the failing tests are not caused by the PR. Have rerun it before and rebased but it keeps failing cc: @potiuk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #25869: Fix typo that crashes migration upgrade
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #25869:
URL: https://github.com/apache/airflow/pull/25869#issuecomment-1222288722
I think those updated tests are detecting one more problem with downgrade :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ephraimbuddy merged pull request #25869: Fix migration issues and tighten the CI upgrade/downgrade test
Posted by GitBox <gi...@apache.org>.
ephraimbuddy merged PR #25869:
URL: https://github.com/apache/airflow/pull/25869
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ephraimbuddy commented on pull request #25869: Fix typo that crashes migration upgrade
Posted by GitBox <gi...@apache.org>.
ephraimbuddy commented on PR #25869:
URL: https://github.com/apache/airflow/pull/25869#issuecomment-1222410613
> I think those updated tests are detecting one more problem with downgrade :)
Yes. A couple more problem. I'm attempting fixes now and tightening the tests further
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #25869: Fix migration issues and tighten the CI upgrade/downgrade test
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #25869:
URL: https://github.com/apache/airflow/pull/25869#issuecomment-1223303778
Should be fixed now. please rebase @ephraimbuddy :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #25869: Fix migration issues and tighten the CI upgrade/downgrade test
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #25869:
URL: https://github.com/apache/airflow/pull/25869#issuecomment-1223191355
Possible fix to Google failing prod image tests: https://github.com/apache/airflow/pull/25886
(BTW. It's great we have the tests - they are finding some unexpected problems our users would have only see after they got the release in their hands - seems that there is an implicit dependency in google provider's dependencies on protobuf version)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org