You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "asl3 (via GitHub)" <gi...@apache.org> on 2023/05/26 01:14:01 UTC
[GitHub] [spark] asl3 opened a new pull request, #41323: [WIP][SPARK-42298] Assign name to _LEGACY_ERROR_TEMP_2132
asl3 opened a new pull request, #41323:
URL: https://github.com/apache/spark/pull/41323
### What changes were proposed in this pull request?
The PR assigns a more descriptive name to the error class _LEGACY_ERROR_TEMP_2132.
### Why are the changes needed?
This change Improves the error framework by making the error name more descriptive.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Tested with existing test cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] asl3 closed pull request #41323: [WIP][SPARK-42298] Assign name to _LEGACY_ERROR_TEMP_2132
Posted by "asl3 (via GitHub)" <gi...@apache.org>.
asl3 closed pull request #41323: [WIP][SPARK-42298] Assign name to _LEGACY_ERROR_TEMP_2132
URL: https://github.com/apache/spark/pull/41323
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #41323: [WIP][SPARK-42298] Assign name to _LEGACY_ERROR_TEMP_2132
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on PR #41323:
URL: https://github.com/apache/spark/pull/41323#issuecomment-1567431331
It seems this is a duplicate of https://github.com/apache/spark/pull/40632
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] asl3 commented on pull request #41323: [WIP][SPARK-42298] Assign name to _LEGACY_ERROR_TEMP_2132
Posted by "asl3 (via GitHub)" <gi...@apache.org>.
asl3 commented on PR #41323:
URL: https://github.com/apache/spark/pull/41323#issuecomment-1565029985
> @asl3 Can you reproduce the error from user space? If so, please, add a test otherwise we should convert this to an internal error.
marked as internal error since error is difficult to reproduce from user space
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srielau commented on a diff in pull request #41323: [WIP][SPARK-42298] Assign name to _LEGACY_ERROR_TEMP_2132
Posted by "srielau (via GitHub)" <gi...@apache.org>.
srielau commented on code in PR #41323:
URL: https://github.com/apache/spark/pull/41323#discussion_r1207052370
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -1574,6 +1574,12 @@
],
"sqlState" : "42617"
},
+ "PARSE_JSON_STRUCTS_FORBIDDEN" : {
+ "message" : [
+ "Parsing JSON arrays as structs is forbidden."
Review Comment:
```suggestion
"Parsing JSON arrays as structs is not allowed."
```
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -1574,6 +1574,12 @@
],
"sqlState" : "42617"
},
+ "PARSE_JSON_STRUCTS_FORBIDDEN" : {
+ "message" : [
+ "Parsing JSON arrays as structs is forbidden."
+ ],
+ "sqlState": "00T"
Review Comment:
```suggestion
"sqlState": "2203G"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org