You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@apache.org> on 2019/03/16 00:02:42 UTC
Review Request 70223: Made `StorageLocalResourceProviderProcess` no
longer exposed.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70223/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier and Jan Schlicht.
Repository: mesos
Description
-------
Since we now moved the CSI calling logics to `v0::VolumeManagerProcess`,
SLRP tests no longer rely on intercepting member function dispatches of
`StorageLocalResourceProviderProcess`, so we undo the exposure made in
r/69827.
Diffs
-----
src/Makefile.am d451d7cabe3bf5d4f5039cfac5de1b03ef891d07
src/resource_provider/storage/provider.cpp fea623c292158deb1b4b4b9ab1ac208031471519
src/resource_provider/storage/provider_process.hpp a5536b3d735e01eb1c4dc52d0602d973155f3c93
Diff: https://reviews.apache.org/r/70223/diff/1/
Testing
-------
make check
Thanks,
Chun-Hung Hsiao
Re: Review Request 70223: Made `StorageLocalResourceProviderProcess`
no longer exposed.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70223/
-----------------------------------------------------------
(Updated March 27, 2019, 6:04 a.m.)
Review request for mesos, Benjamin Bannier and Jan Schlicht.
Changes
-------
Rebased and updated the description.
Bugs: MESOS-9622
https://issues.apache.org/jira/browse/MESOS-9622
Repository: mesos
Description (updated)
-------
Since we now moved the CSI calling logics to `v0::VolumeManagerProcess`,
SLRP tests no longer rely on intercepting member function dispatches of
`StorageLocalResourceProviderProcess`, so we undo the exposure made in
r/69827 (commit e9d2a296081).
Diffs (updated)
-----
src/Makefile.am bcafe48b2105575371464a29783bc6f3f1c2cf8d
src/resource_provider/storage/provider.cpp 2711503cdb58cb9b34af8c9fad0908c5f788a2af
src/resource_provider/storage/provider_process.hpp a5536b3d735e01eb1c4dc52d0602d973155f3c93
Diff: https://reviews.apache.org/r/70223/diff/4/
Changes: https://reviews.apache.org/r/70223/diff/3-4/
Testing
-------
make check
Thanks,
Chun-Hung Hsiao
Re: Review Request 70223: Made `StorageLocalResourceProviderProcess`
no longer exposed.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70223/#review213759
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['70168', '70169', '70213', '70214', '70215', '70216', '70217', '70222', '70223']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2971/mesos-review-70223
Relevant logs:
- [mesos-tests-cmake.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2971/mesos-review-70223/logs/mesos-tests-cmake.log):
```
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(3500): warning C4996: 'inet_ntoa': Use inet_ntop() or InetNtop() instead or define _WINSOCK_DEPRECATED_NO_WARNINGS to disable deprecated API warnings [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(3501): warning C4996: 'sprintf': This function or variable may be unsafe. Consider using sprintf_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(3479): warning C4101: 'addrstr': unreferenced local variable [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\recordio.c(170): warning C4267: '=': conversion from 'size_t' to 'int32_t', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\mt_adaptor.c(496): warning C4244: '=': conversion from 'time_t' to 'int32_t', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\winport.c(256): warning C4090: 'function': different 'const' qualifiers [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\winport.c(166): warning C4716: 'pthread_cond_broadcast': must return a value [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\winport.c(205): warning C4716: 'pthread_cond_wait': must return a value [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(124): warning C4996: 'fopen': This function or variable may be unsafe. Consider using fopen_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(128): warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(279): warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(301): warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(368): warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(372): warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(512): warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(543): warning C4996: 'strcpy': This function or variable may be unsafe. Consider using strcpy_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(548): warning C4996: 'fopen': This function or variable may be unsafe. Consider using fopen_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(569): warning C4996: 'strcpy': This function or variable may be unsafe. Consider using strcpy_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
"D:\DCOS\mesos\src\tests\mesos-tests.vcxproj" (default target) (1) ->
"D:\DCOS\mesos\src\mesos.vcxproj" (default target) (23) ->
(ClCompile target) ->
d:\dcos\mesos\mesos\src\csi\v0_volume_manager.cpp(258): error C2397: conversion from 'google::protobuf::int64' to 'Bytes' requires a narrowing conversion [D:\DCOS\mesos\src\mesos.vcxproj]
172 Warning(s)
1 Error(s)
Time Elapsed 00:09:15.33
```
- Mesos Reviewbot Windows
On March 16, 2019, 12:02 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70223/
> -----------------------------------------------------------
>
> (Updated March 16, 2019, 12:02 a.m.)
>
>
> Review request for mesos, Benjamin Bannier and Jan Schlicht.
>
>
> Bugs: MESOS-9622
> https://issues.apache.org/jira/browse/MESOS-9622
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Since we now moved the CSI calling logics to `v0::VolumeManagerProcess`,
> SLRP tests no longer rely on intercepting member function dispatches of
> `StorageLocalResourceProviderProcess`, so we undo the exposure made in
> r/69827.
>
>
> Diffs
> -----
>
> src/Makefile.am d451d7cabe3bf5d4f5039cfac5de1b03ef891d07
> src/resource_provider/storage/provider.cpp fea623c292158deb1b4b4b9ab1ac208031471519
> src/resource_provider/storage/provider_process.hpp a5536b3d735e01eb1c4dc52d0602d973155f3c93
>
>
> Diff: https://reviews.apache.org/r/70223/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 70223: Made `StorageLocalResourceProviderProcess`
no longer exposed.
Posted by Benjamin Bannier <be...@mesosphere.io>.
> On March 26, 2019, 4:26 p.m., Benjamin Bannier wrote:
> > Looks good, but it would be great to actually excercise and test this.
This was intended for https://reviews.apache.org/r/70285/.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70223/#review214051
-----------------------------------------------------------
On March 16, 2019, 1:02 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70223/
> -----------------------------------------------------------
>
> (Updated March 16, 2019, 1:02 a.m.)
>
>
> Review request for mesos, Benjamin Bannier and Jan Schlicht.
>
>
> Bugs: MESOS-9622
> https://issues.apache.org/jira/browse/MESOS-9622
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Since we now moved the CSI calling logics to `v0::VolumeManagerProcess`,
> SLRP tests no longer rely on intercepting member function dispatches of
> `StorageLocalResourceProviderProcess`, so we undo the exposure made in
> r/69827.
>
>
> Diffs
> -----
>
> src/Makefile.am d451d7cabe3bf5d4f5039cfac5de1b03ef891d07
> src/resource_provider/storage/provider.cpp fea623c292158deb1b4b4b9ab1ac208031471519
> src/resource_provider/storage/provider_process.hpp a5536b3d735e01eb1c4dc52d0602d973155f3c93
>
>
> Diff: https://reviews.apache.org/r/70223/diff/3/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 70223: Made `StorageLocalResourceProviderProcess`
no longer exposed.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70223/#review214051
-----------------------------------------------------------
Ship it!
Looks good, but it would be great to actually excercise and test this.
- Benjamin Bannier
On March 16, 2019, 1:02 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70223/
> -----------------------------------------------------------
>
> (Updated March 16, 2019, 1:02 a.m.)
>
>
> Review request for mesos, Benjamin Bannier and Jan Schlicht.
>
>
> Bugs: MESOS-9622
> https://issues.apache.org/jira/browse/MESOS-9622
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Since we now moved the CSI calling logics to `v0::VolumeManagerProcess`,
> SLRP tests no longer rely on intercepting member function dispatches of
> `StorageLocalResourceProviderProcess`, so we undo the exposure made in
> r/69827.
>
>
> Diffs
> -----
>
> src/Makefile.am d451d7cabe3bf5d4f5039cfac5de1b03ef891d07
> src/resource_provider/storage/provider.cpp fea623c292158deb1b4b4b9ab1ac208031471519
> src/resource_provider/storage/provider_process.hpp a5536b3d735e01eb1c4dc52d0602d973155f3c93
>
>
> Diff: https://reviews.apache.org/r/70223/diff/3/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 70223: Made `StorageLocalResourceProviderProcess`
no longer exposed.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
> On March 26, 2019, 3:35 p.m., Benjamin Bannier wrote:
> > Looks good!
> >
> > What do you think about referencing `e9d2a296081` instead of `r/69827` in the commit message?
Hmm the SHA might change if there's a rebase before committing it into the master branch. How about having a complete URL of r/69827?
- Chun-Hung
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70223/#review214052
-----------------------------------------------------------
On March 16, 2019, 12:02 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70223/
> -----------------------------------------------------------
>
> (Updated March 16, 2019, 12:02 a.m.)
>
>
> Review request for mesos, Benjamin Bannier and Jan Schlicht.
>
>
> Bugs: MESOS-9622
> https://issues.apache.org/jira/browse/MESOS-9622
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Since we now moved the CSI calling logics to `v0::VolumeManagerProcess`,
> SLRP tests no longer rely on intercepting member function dispatches of
> `StorageLocalResourceProviderProcess`, so we undo the exposure made in
> r/69827.
>
>
> Diffs
> -----
>
> src/Makefile.am d451d7cabe3bf5d4f5039cfac5de1b03ef891d07
> src/resource_provider/storage/provider.cpp fea623c292158deb1b4b4b9ab1ac208031471519
> src/resource_provider/storage/provider_process.hpp a5536b3d735e01eb1c4dc52d0602d973155f3c93
>
>
> Diff: https://reviews.apache.org/r/70223/diff/3/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 70223: Made `StorageLocalResourceProviderProcess`
no longer exposed.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
> On March 26, 2019, 3:35 p.m., Benjamin Bannier wrote:
> > Looks good!
> >
> > What do you think about referencing `e9d2a296081` instead of `r/69827` in the commit message?
>
> Chun-Hung Hsiao wrote:
> Hmm the SHA might change if there's a rebase before committing it into the master branch. How about having a complete URL of r/69827?
Wait I was mistaken. Yeah sure let me do that.
- Chun-Hung
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70223/#review214052
-----------------------------------------------------------
On March 16, 2019, 12:02 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70223/
> -----------------------------------------------------------
>
> (Updated March 16, 2019, 12:02 a.m.)
>
>
> Review request for mesos, Benjamin Bannier and Jan Schlicht.
>
>
> Bugs: MESOS-9622
> https://issues.apache.org/jira/browse/MESOS-9622
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Since we now moved the CSI calling logics to `v0::VolumeManagerProcess`,
> SLRP tests no longer rely on intercepting member function dispatches of
> `StorageLocalResourceProviderProcess`, so we undo the exposure made in
> r/69827.
>
>
> Diffs
> -----
>
> src/Makefile.am d451d7cabe3bf5d4f5039cfac5de1b03ef891d07
> src/resource_provider/storage/provider.cpp fea623c292158deb1b4b4b9ab1ac208031471519
> src/resource_provider/storage/provider_process.hpp a5536b3d735e01eb1c4dc52d0602d973155f3c93
>
>
> Diff: https://reviews.apache.org/r/70223/diff/3/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 70223: Made `StorageLocalResourceProviderProcess`
no longer exposed.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70223/#review214052
-----------------------------------------------------------
Ship it!
Looks good!
What do you think about referencing `e9d2a296081` instead of `r/69827` in the commit message?
- Benjamin Bannier
On March 16, 2019, 1:02 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70223/
> -----------------------------------------------------------
>
> (Updated March 16, 2019, 1:02 a.m.)
>
>
> Review request for mesos, Benjamin Bannier and Jan Schlicht.
>
>
> Bugs: MESOS-9622
> https://issues.apache.org/jira/browse/MESOS-9622
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Since we now moved the CSI calling logics to `v0::VolumeManagerProcess`,
> SLRP tests no longer rely on intercepting member function dispatches of
> `StorageLocalResourceProviderProcess`, so we undo the exposure made in
> r/69827.
>
>
> Diffs
> -----
>
> src/Makefile.am d451d7cabe3bf5d4f5039cfac5de1b03ef891d07
> src/resource_provider/storage/provider.cpp fea623c292158deb1b4b4b9ab1ac208031471519
> src/resource_provider/storage/provider_process.hpp a5536b3d735e01eb1c4dc52d0602d973155f3c93
>
>
> Diff: https://reviews.apache.org/r/70223/diff/3/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>