[GitHub] [geode] jmelchio commented on a change in pull request #7063: GEODE-9746: do not logout old subjects immediately when we get a new subject for the same uniqueId

[GitBox <gi...@apache.org>]

jmelchio commented on a change in pull request #7063:
URL: https://github.com/apache/geode/pull/7063#discussion_r740519610



##########
File path: geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ClientUserAuths.java
##########
@@ -38,7 +43,12 @@
       new ConcurrentHashMap<>();
   private final ConcurrentMap<String, UserAuthAttributes> cqNameVsUserAuth =
       new ConcurrentHashMap<>();
-  private final ConcurrentMap<Long, Subject> uniqueIdVsSubject = new ConcurrentHashMap<>();
+  // use a list to store all the subjects that's created for this user id
+  // it's observed that even in the non-expirable credential case, the will be multiple

Review comment:
       Assume `the` is meant to be `there`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org