[PR] risc-v:Unify module compilation options [nuttx]

["anjiahao1 (via GitHub)" <gi...@apache.org>]

anjiahao1 opened a new pull request, #14064:
URL: https://github.com/apache/nuttx/pull/14064

   ## Summary
   risc-v:Unify module compilation options
   ## Impact
   risc-v
   ## Testing
   `rv-virt:knsh` build it,and run it with qemu


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] risc-v:Unify module compilation options [nuttx]

["xiaoxiang781216 (via GitHub)" <gi...@apache.org>]

xiaoxiang781216 commented on code in PR #14064:
URL: https://github.com/apache/nuttx/pull/14064#discussion_r1795801585


##########
arch/risc-v/src/common/Toolchain.defs:
##########
@@ -411,8 +411,15 @@ CELFFLAGS = $(CFLAGS) -fvisibility=hidden
 CXXELFFLAGS = $(CXXFLAGS) -fvisibility=hidden
 
 LDELFFLAGS = -r -e main
+ifeq ($(CONFIG_ARCH_RV32),y)
+  LDELFFLAGS += --oformat elf32-littleriscv
+else
+  LDELFFLAGS += --oformat elf64-littleriscv
+endif
+
 LDELFFLAGS += -T $(call CONVERT_PATH,$(TOPDIR)$(DELIM)binfmt$(DELIM)libelf$(DELIM)gnu-elf.ld)
 
+

Review Comment:
   remove this line



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] risc-v:Unify module compilation options [nuttx]

["nuttxpr (via GitHub)" <gi...@apache.org>]

nuttxpr commented on PR #14064:
URL: https://github.com/apache/nuttx/pull/14064#issuecomment-2405210979

   [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues)
   
   
   
   **No, this PR does not meet the NuttX Requirements.**
   
   **Missing Information:**
   
   * **Summary:**
       * **Why** is this change necessary? What problem does it solve?
       * **What** specific module compilation options are being unified?
       * **How** are the options being unified? What is the new, consistent approach?
   * **Impact:**
       * Provide specific details for each impact category (e.g., which architectures, boards, drivers are affected). 
       * Instead of just stating "risc-v," explain the impact on RISC-V.  
   * **Testing:**
       * **Insufficient detail:** "Build it and run it with qemu" is not descriptive enough.
       * **No logs:** Provide actual testing logs from before and after the change. 
   
   **Recommendations:**
   
   1. **Expand the Summary:** Clearly articulate the problem, the solution, and the technical details of the change.
   2. **Complete the Impact Section:** Address each category with specific information. If an impact is "NO," briefly explain why.
   3. **Provide Detailed Testing Information:** 
       * Specify the exact build host and target environments.
       * Include relevant commands used for building and testing.
       * Share actual log output that demonstrates the change's effect. 
   
   A well-structured PR with complete information will significantly increase its chances of being reviewed and merged quickly. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] risc-v:Unify module compilation options [nuttx]

["xiaoxiang781216 (via GitHub)" <gi...@apache.org>]

xiaoxiang781216 merged PR #14064:
URL: https://github.com/apache/nuttx/pull/14064


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org