You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "shirenchuang (via GitHub)" <gi...@apache.org> on 2023/08/10 10:04:04 UTC

[GitHub] [rocketmq] shirenchuang opened a new pull request, #7157: [Feature 7155] add errlog when cmd err

shirenchuang opened a new pull request, #7157:
URL: https://github.com/apache/rocketmq/pull/7157

   <!-- Please make sure the target branch is right. In most case, the target branch should be `develop`. -->
   
   ### Which Issue(s) This PR Fixes
   
   <!-- Please ensure that the related issue has already been created, and [link this pull request to that issue using keywords](<https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword>) to ensure automatic closure. -->
   
   Fixes #7155 
   
   ### Brief Description
   
   <!-- Write a brief description for your pull request to help the maintainer understand the reasons behind your changes. -->
   
   ### How Did You Test This Change?
   
   
   <!-- In order to ensure the code quality of Apache RocketMQ, we expect every pull request to have undergone thorough testing. -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [rocketmq] codecov-commenter commented on pull request #7157: [Feature 7155] add errlog when cmd err

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #7157:
URL: https://github.com/apache/rocketmq/pull/7157#issuecomment-1672967225

   ## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/7157?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   > Merging [#7157](https://app.codecov.io/gh/apache/rocketmq/pull/7157?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (ca233ee) into [develop](https://app.codecov.io/gh/apache/rocketmq/commit/8741ff8c9b3bdbfc97976285affa7ea35c81243c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (8741ff8) will **increase** coverage by `0.00%`.
   > The diff coverage is `0.00%`.
   
   ```diff
   @@            Coverage Diff             @@
   ##             develop    #7157   +/-   ##
   ==========================================
     Coverage      42.46%   42.47%           
   - Complexity      9348     9349    +1     
   ==========================================
     Files           1149     1149           
     Lines          82042    82043    +1     
     Branches       10701    10701           
   ==========================================
   + Hits           34843    34847    +4     
   - Misses         42836    42837    +1     
   + Partials        4363     4359    -4     
   ```
   
   
   | [Files Changed](https://app.codecov.io/gh/apache/rocketmq/pull/7157?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...n/java/org/apache/rocketmq/srvutil/ServerUtil.java](https://app.codecov.io/gh/apache/rocketmq/pull/7157?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3J2dXRpbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvc3J2dXRpbC9TZXJ2ZXJVdGlsLmphdmE=) | `0.00% <0.00%> (ø)` | |
   
   ... and [21 files with indirect coverage changes](https://app.codecov.io/gh/apache/rocketmq/pull/7157/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [rocketmq] xdkxlk merged pull request #7157: [Feature 7155] add errlog when cmd err

Posted by "xdkxlk (via GitHub)" <gi...@apache.org>.
xdkxlk merged PR #7157:
URL: https://github.com/apache/rocketmq/pull/7157


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [rocketmq] RongtongJin commented on pull request #7157: [Feature 7155] add errlog when cmd err

Posted by "RongtongJin (via GitHub)" <gi...@apache.org>.
RongtongJin commented on PR #7157:
URL: https://github.com/apache/rocketmq/pull/7157#issuecomment-1674124938

   LGTM~


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org