You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@trafficserver.apache.org by GitBox <gi...@apache.org> on 2020/04/20 17:00:31 UTC

[GitHub] [trafficserver] shukitchan commented on a change in pull request #6571: Lua plugin number of states configuration and stats printing

shukitchan commented on a change in pull request #6571:
URL: https://github.com/apache/trafficserver/pull/6571#discussion_r411540669



##########
File path: plugins/lua/ts_lua.c
##########
@@ -26,36 +26,311 @@
 
 #define TS_LUA_MAX_STATE_COUNT 256
 
+#define TS_LUA_STATS_TIMEOUT 1000   // 1s

Review comment:
       can this be configurable as well? 
   I think this may be too much initially. Perhaps a higher number as the default? like 5s ?
   Also it may be a good way to disable stats if the timeout is set to 0? 
   
   That said, I think we can still merge this first and submit another PR later for this. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org