[GitHub] [solr] erichaagdev commented on a diff in pull request #1319: Gradle optimizations

["erichaagdev (via GitHub)" <gi...@apache.org>]

erichaagdev commented on code in PR #1319:
URL: https://github.com/apache/solr/pull/1319#discussion_r1092291823


##########
gradle/testing/defaults-tests.gradle:
##########
@@ -179,3 +182,20 @@ allprojects {
     }
   }
 }
+
+class LoggingFileArgumentProvider implements CommandLineArgumentProvider {
+  @InputFile
+  @PathSensitive(PathSensitivity.RELATIVE)
+  File loggingConfigFile

Review Comment:
   I suggest using an appropriate lazy file type, versus `File`: https://docs.gradle.org/current/userguide/lazy_configuration.html#working_with_files_in_lazy_properties



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org