You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Matthew Jacobs (Code Review)" <ge...@cloudera.org> on 2017/02/15 22:12:07 UTC
[Impala-ASF-CR] IMPALA-4937: Remove unused kudu scanner keep alive variable
Matthew Jacobs has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6021
Change subject: IMPALA-4937: Remove unused kudu scanner keep alive variable
......................................................................
IMPALA-4937: Remove unused kudu scanner keep alive variable
gflag kudu_scanner_keep_alive_period_us is defined but not
used. The same functionality is provided by
kudu_scanner_keep_alive_period_sec (in seconds), which works.
The kudu_scanner_keep_alive_period_us flag is removed by
this patch.
Change-Id: I99f56f93f1ff8543cbe415542464a053b24968e2
---
M be/src/exec/kudu-scan-node.cc
1 file changed, 0 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/21/6021/1
--
To view, visit http://gerrit.cloudera.org:8080/6021
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I99f56f93f1ff8543cbe415542464a053b24968e2
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
[Impala-ASF-CR] IMPALA-4937: Remove unused kudu scanner keep alive variable
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-4937: Remove unused kudu scanner keep alive variable
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/6021
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I99f56f93f1ff8543cbe415542464a053b24968e2
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4937: Remove unused kudu scanner keep alive variable
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-4937: Remove unused kudu scanner keep alive variable
......................................................................
IMPALA-4937: Remove unused kudu scanner keep alive variable
gflag kudu_scanner_keep_alive_period_us is defined but not
used. The same functionality is provided by
kudu_scanner_keep_alive_period_sec (in seconds), which works.
The kudu_scanner_keep_alive_period_us flag is removed by
this patch.
Change-Id: I99f56f93f1ff8543cbe415542464a053b24968e2
Reviewed-on: http://gerrit.cloudera.org:8080/6021
Reviewed-by: Sailesh Mukil <sa...@cloudera.com>
Reviewed-by: Alex Behm <al...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M be/src/exec/kudu-scan-node.cc
1 file changed, 0 insertions(+), 3 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Sailesh Mukil: Looks good to me, but someone else must approve
Alex Behm: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/6021
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I99f56f93f1ff8543cbe415542464a053b24968e2
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
[Impala-ASF-CR] IMPALA-4937: Remove unused kudu scanner keep alive variable
Posted by "Sailesh Mukil (Code Review)" <ge...@cloudera.org>.
Sailesh Mukil has posted comments on this change.
Change subject: IMPALA-4937: Remove unused kudu scanner keep alive variable
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/6021
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I99f56f93f1ff8543cbe415542464a053b24968e2
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4937: Remove unused kudu scanner keep alive variable
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change.
Change subject: IMPALA-4937: Remove unused kudu scanner keep alive variable
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6021
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I99f56f93f1ff8543cbe415542464a053b24968e2
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4937: Remove unused kudu scanner keep alive variable
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-4937: Remove unused kudu scanner keep alive variable
......................................................................
Patch Set 1:
Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/279/
--
To view, visit http://gerrit.cloudera.org:8080/6021
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I99f56f93f1ff8543cbe415542464a053b24968e2
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-HasComments: No