You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "mattisonchao (via GitHub)" <gi...@apache.org> on 2023/11/07 03:32:28 UTC
[PR] [fix][ml] Fix wrong configuration passed to managed ledger when deleting [pulsar]
mattisonchao opened a new pull request, #21529:
URL: https://github.com/apache/pulsar/pull/21529
### Motivation
#21093 Delete the topic policy before the managed ledger configuration building. It will pass the wrong managed ledger configuration to the backend and affect offloading etc.
### Modifications
- Get managed ledger configuration before deleting topic policies.
### Verifying this change
- [x] Make sure that the change passes the CI checks.
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][ml] Fix wrong configuration passed to managed ledger when deleting [pulsar]
Posted by "Technoboy- (via GitHub)" <gi...@apache.org>.
Technoboy- commented on PR #21529:
URL: https://github.com/apache/pulsar/pull/21529#issuecomment-1822027831
`topicPoliciesFuture` throw exception because race condition occurs in `getManagedLedgerConfig`.
Need to handle exception for `topicPoliciesFuture`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][ml] Fix wrong configuration passed to managed ledger when deleting [pulsar]
Posted by "mattisonchao (via GitHub)" <gi...@apache.org>.
mattisonchao closed pull request #21529: [fix][ml] Fix wrong configuration passed to managed ledger when deleting
URL: https://github.com/apache/pulsar/pull/21529
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][ml] Fix wrong configuration passed to managed ledger when deleting [pulsar]
Posted by "mattisonchao (via GitHub)" <gi...@apache.org>.
mattisonchao commented on PR #21529:
URL: https://github.com/apache/pulsar/pull/21529#issuecomment-1797778345
I am unsure at first glance. I think the test is challenging to add. I am considering whether it is worth to spend that time. :/
@codelipenghui, do you think this test is necessary? I mean the problem looks pretty straightforward.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][ml] Fix wrong configuration passed to managed ledger when deleting [pulsar]
Posted by "mattisonchao (via GitHub)" <gi...@apache.org>.
mattisonchao closed pull request #21529: [fix][ml] Fix wrong configuration passed to managed ledger when deleting
URL: https://github.com/apache/pulsar/pull/21529
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][ml] Fix wrong configuration passed to managed ledger when deleting [pulsar]
Posted by "mattisonchao (via GitHub)" <gi...@apache.org>.
mattisonchao commented on PR #21529:
URL: https://github.com/apache/pulsar/pull/21529#issuecomment-1797966345
I will add the test to avoid regression. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org