You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Vitalyi Brodetskyi <vb...@hortonworks.com> on 2014/01/31 15:10:06 UTC

Review Request 17588: We should set content type(do encoding), for data in body. URLStreamProvider.processURL

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17588/
-----------------------------------------------------------

Review request for Ambari, Dmitro Lisnichenko and Nate Cole.


Bugs: AMBARI-4482
    https://issues.apache.org/jira/browse/AMBARI-4482


Repository: ambari


Description
-------

.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/api/services/ProxyService.java ce933a9 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/URLStreamProvider.java 2847c05 
  ambari-server/src/test/java/org/apache/ambari/server/api/services/ProxyServiceTest.java 057772b 

Diff: https://reviews.apache.org/r/17588/diff/


Testing
-------


Thanks,

Vitalyi Brodetskyi


Re: Review Request 17588: We should set content type(do encoding), for data in body. URLStreamProvider.processURL

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17588/#review33426
-----------------------------------------------------------

Ship it!


Ship It!

- Dmitro Lisnichenko


On Feb. 3, 2014, 12:25 p.m., Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17588/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2014, 12:25 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Nate Cole.
> 
> 
> Bugs: AMBARI-4482
>     https://issues.apache.org/jira/browse/AMBARI-4482
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> .
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/ProxyService.java ce933a9 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/URLStreamProvider.java 2847c05 
>   ambari-server/src/test/java/org/apache/ambari/server/api/services/ProxyServiceTest.java 057772b 
> 
> Diff: https://reviews.apache.org/r/17588/diff/
> 
> 
> Testing
> -------
> 
> Tests run: 1353, Failures: 0, Errors: 0, Skipped: 7
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>


Re: Review Request 17588: We should set content type(do encoding), for data in body. URLStreamProvider.processURL

Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17588/
-----------------------------------------------------------

(Updated Feb. 3, 2014, 12:25 p.m.)


Review request for Ambari, Dmitro Lisnichenko and Nate Cole.


Changes
-------

test corrections. not very important


Bugs: AMBARI-4482
    https://issues.apache.org/jira/browse/AMBARI-4482


Repository: ambari


Description
-------

.


Diffs (updated)
-----

  ambari-server/src/main/java/org/apache/ambari/server/api/services/ProxyService.java ce933a9 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/URLStreamProvider.java 2847c05 
  ambari-server/src/test/java/org/apache/ambari/server/api/services/ProxyServiceTest.java 057772b 

Diff: https://reviews.apache.org/r/17588/diff/


Testing
-------

Tests run: 1353, Failures: 0, Errors: 0, Skipped: 7


Thanks,

Vitalyi Brodetskyi


Re: Review Request 17588: We should set content type(do encoding), for data in body. URLStreamProvider.processURL

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17588/#review33321
-----------------------------------------------------------

Ship it!


Ship It!

- Dmitro Lisnichenko


On Jan. 31, 2014, 2:54 p.m., Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17588/
> -----------------------------------------------------------
> 
> (Updated Jan. 31, 2014, 2:54 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Nate Cole.
> 
> 
> Bugs: AMBARI-4482
>     https://issues.apache.org/jira/browse/AMBARI-4482
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> .
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/ProxyService.java ce933a9 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/URLStreamProvider.java 2847c05 
>   ambari-server/src/test/java/org/apache/ambari/server/api/services/ProxyServiceTest.java 057772b 
> 
> Diff: https://reviews.apache.org/r/17588/diff/
> 
> 
> Testing
> -------
> 
> Tests run: 1353, Failures: 0, Errors: 0, Skipped: 7
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>


Re: Review Request 17588: We should set content type(do encoding), for data in body. URLStreamProvider.processURL

Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17588/
-----------------------------------------------------------

(Updated Jan. 31, 2014, 2:54 p.m.)


Review request for Ambari, Dmitro Lisnichenko and Nate Cole.


Bugs: AMBARI-4482
    https://issues.apache.org/jira/browse/AMBARI-4482


Repository: ambari


Description
-------

.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/api/services/ProxyService.java ce933a9 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/URLStreamProvider.java 2847c05 
  ambari-server/src/test/java/org/apache/ambari/server/api/services/ProxyServiceTest.java 057772b 

Diff: https://reviews.apache.org/r/17588/diff/


Testing (updated)
-------

Tests run: 1353, Failures: 0, Errors: 0, Skipped: 7


Thanks,

Vitalyi Brodetskyi


Re: Review Request 17588: We should set content type(do encoding), for data in body. URLStreamProvider.processURL

Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17588/#review33316
-----------------------------------------------------------

Ship it!


Ship It!

- Nate Cole


On Jan. 31, 2014, 9:10 a.m., Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17588/
> -----------------------------------------------------------
> 
> (Updated Jan. 31, 2014, 9:10 a.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Nate Cole.
> 
> 
> Bugs: AMBARI-4482
>     https://issues.apache.org/jira/browse/AMBARI-4482
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> .
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/ProxyService.java ce933a9 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/URLStreamProvider.java 2847c05 
>   ambari-server/src/test/java/org/apache/ambari/server/api/services/ProxyServiceTest.java 057772b 
> 
> Diff: https://reviews.apache.org/r/17588/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>