You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Konstantin Shvachko (JIRA)" <ji...@apache.org> on 2010/06/03 21:24:56 UTC
[jira] Commented: (HDFS-1185) Remove duplicate now() functions in
DataNode, FSNamesystem
[ https://issues.apache.org/jira/browse/HDFS-1185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12875259#action_12875259 ]
Konstantin Shvachko commented on HDFS-1185:
-------------------------------------------
Sounds like a good idea. One nit. It would be nice to use import static, like this
{code}
import static org.apache.hadoop.hdfs.server.common.Util.now;
{code}
Then direct calls to {{now()}} in FDNamesystem and DataNode will remain unchanged. In other places it will just say {{now}}.
> Remove duplicate now() functions in DataNode, FSNamesystem
> ----------------------------------------------------------
>
> Key: HDFS-1185
> URL: https://issues.apache.org/jira/browse/HDFS-1185
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: data-node, name-node
> Reporter: Jeff
> Priority: Minor
> Attachments: HDFS-1185.patch
>
>
> An identical now() function is defined in Util, DataNode, and FSNamesystem. This patch removes the latter two and converts all calls to use the Util.now function.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.