You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "cloud-fan (via GitHub)" <gi...@apache.org> on 2023/04/12 02:27:24 UTC

[GitHub] [spark] cloud-fan commented on pull request #40743: [SPARK-42597][SQL][FOLLOW-UP] Exclude `EqualNullSafe` when unwrapping date type to timestamp type

cloud-fan commented on PR #40743:
URL: https://github.com/apache/spark/pull/40743#issuecomment-1504456010

   @wangyum I think we should mention two things:
   1. the current rewrite is incorrect for EqualNullSafe
   2. even if we fix the rewrite, it will contain `If` and can't be pushed down to the data source.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org