[GitHub] [ratis] codings-dan commented on a diff in pull request #670: RATIS-1614. Upgrade Ratis Thirdparty to 1.0.1

[GitBox <gi...@apache.org>]

codings-dan commented on code in PR #670:
URL: https://github.com/apache/ratis/pull/670#discussion_r915734511


##########
pom.xml:
##########
@@ -407,25 +407,25 @@
       <dependency>
         <groupId>io.dropwizard.metrics</groupId>
         <artifactId>metrics-core</artifactId>
-        <version>${dropwizard.version}</version>
+        <version>${shaded.dropwizard.version}</version>
       </dependency>
 
       <dependency>
         <groupId>io.dropwizard.metrics</groupId>
         <artifactId>metrics-jvm</artifactId>
-        <version>${dropwizard.version}</version>
+        <version>${shaded.dropwizard.version}</version>
       </dependency>
 
       <dependency>
         <groupId>io.dropwizard.metrics</groupId>
         <artifactId>metrics-jmx</artifactId>
-        <version>${dropwizard.version}</version>
+        <version>${shaded.dropwizard.version}</version>
       </dependency>
 
       <dependency>
         <groupId>io.dropwizard.metrics</groupId>
         <artifactId>metrics-ganglia</artifactId>
-        <version>${dropwizard.ganglia.version}</version>
+        <version>${shaded.dropwizard.ganglia.version}</version>
       </dependency>

Review Comment:
   @szetszwo Thanks for pointing out the problem, I'm not very familiar with this part, so I missed some changes. I've made a new pull request, please take a look, thanks! see https://github.com/apache/ratis/pull/671



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org