[VOTE] SAMOA 0.3.0 (incubating) RC0

[Gianmarco De Francisci Morales <gd...@apache.org>]

Please vote on releasing the following candidate as Apache SAMOA
(incubating) version 0.3.0.

This release will be the first major release for SAMOA in the incubator.

-------------------------------------------------------------
The commit to be voted on is in the branch "releases/0.3.0-incubating"
(commit 30f86dcaa977c61a634d7a4ac1772d1d7666add0):
http://git-wip-us.apache.org/repos/asf?p=incubator-samoa.git;a=commit;h=30f86dcaa977c61a634d7a4ac1772d1d7666add0

Release artifacts are signed with the following key:
https://people.apache.org/keys/committer/gdfm.asc

The staging repository for this release can be found at:
https://repository.apache.org/content/repositories/staging/org/apache/samoa/samoa/0.3.0-incubating/
-------------------------------------------------------------

Please vote on releasing this package as Apache SAMOA 0.3.0 (incubating).

The vote is open for the next 72 hours and passes if a majority of at least
three +1 PPMC votes are cast.

[ ] +1 Release this package as Apache SAMOA 0.3.0 (incubating)
[ ] -1 Do not release this package because ...

--
Gianmarco

Re: [VOTE] SAMOA 0.3.0 (incubating) RC0

[Justin Mclean <ju...@classsoftware.com>]

Hi,

> We have email correspondence documenting it, and we can directly ask the
> developers of MOA for confirmation.

Having them grant you an Apache licensed version of the code in some public way would be best course of action I think. That however doesn’t need to hold up your first RC / IPMC vote as long as you state that in the vote and that the issue is been looked into and will be resolved before graduation that should be fine.

Thanks,
Justin

Re: [VOTE] SAMOA 0.3.0 (incubating) RC0

[Gianmarco De Francisci Morales <gd...@apache.org>]

Hi,

> Regarding MOA, Yahoo actually received a license to redistribute part of
> it
> > with an ASL inside the SAMOA project from the copyright holders of the
> MOA
> > project.
>
> Is this documented anywhere? Adding it to NOTICE is correct (as
> header/license has changed) [3] but you may want to provide a link to make
> it clear that it’s not Category X licensed code.


There is no public document as this was an agreement between the developers
of MOA and the developers of SAMOA at Yahoo.
We have email correspondence documenting it, and we can directly ask the
developers of MOA for confirmation.

Thanks again for the help,
--
Gianmarco

Re: [VOTE] SAMOA 0.3.0 (incubating) RC0

[Justin Mclean <ju...@classsoftware.com>]

Hi,

> 1) I'll fix the gradle wrapper issue.
> 2) Add a DISCLAIMER file.
> 3) Fix missing headers.
> 4) Add (incubating) to the NOTICE file, and see how to make it more
> standard.
> 5) Fix copyrightNotice string in Globals.java.
> 6) Add Yahoo in the NOTICE file.
> 7) Fix copyrights and author tags in the remaining files.

Sounds great, probably only 1,2 and the GPL issue clarified would need to be done in order to pass an IPMC vote. Other IPMC member may have other views of course.

Re copyrights you might want to look at [4], note the bit about relocations of copyright.

Re author tags if it was code external to Apache, it's best to leave them in, and just don’t add any more while at Apache if that makes sense.

> Regarding MOA, Yahoo actually received a license to redistribute part of it
> with an ASL inside the SAMOA project from the copyright holders of the MOA
> project.

Is this documented anywhere? Adding it to NOTICE is correct (as header/license has changed) [3] but you may want to provide a link to make it clear that it’s not Category X licensed code.

> It is not uncommon for software to have double licenses.

It’s not uncommon, but that doesn’t seem to be the case for the public version of MOA on google code [1] or it's pom.xml [2].

Thanks,
Justin

1. https://code.google.com/p/moa/
2. https://code.google.com/p/moa/source/browse/moa/pom.xml
3. http://www.apache.org/dev/licensing-howto.html#modifications-to-notice
4. http://www.apache.org/legal/src-headers.html#headers

Re: [VOTE] SAMOA 0.3.0 (incubating) RC0

[Gianmarco De Francisci Morales <gd...@apache.org>]

Hi Justin,

I don't mind at all, rather your feedback is very welcome.
It's our first release and my first time as a release manager, so any
feedback is highly appreciated.

Given the issues you highlighted, I'll cancel the current vote and prepare
a new RC1.

1) I'll fix the gradle wrapper issue.
2) Add a DISCLAIMER file.
3) Fix missing headers.
4) Add (incubating) to the NOTICE file, and see how to make it more
standard.
5) Fix copyrightNotice string in Globals.java.
6) Add Yahoo in the NOTICE file.
7) Fix copyrights and author tags in the remaining files.

Regarding MOA, Yahoo actually received a license to redistribute part of it
with an ASL inside the SAMOA project from the copyright holders of the MOA
project.
This happened when we first open-sourced SAMOA, well before we entered
incubation.
It is not uncommon for software to have double licenses.

Thanks,


--
Gianmarco

On 1 July 2015 at 23:29, Justin Mclean <ju...@classsoftware.com> wrote:

> Hi,
>
> Hope you don’t mind the intrustion but I thought I’d take a look at your
> RC. As I only have a limited knowledge of your project I may of got a few
> things wrong.
>
> There's a couple of things I would consider blockers if it was put to a
> vote on the IPMC list.
>
> There is a jar in the source release:
> ./samoa-0.3.0-incubating/bin/s4-build/gradle-wrapper-1.4.jar
>
> Having a jar in a source release is not possible. [1] This exact issue has
> come up on the incubator before you might want to search for it and see how
> it was resolved by other projects.
>
> From what I can see MOA is under GPL which is a category X license not an
> Apache compatable license [3] You may want to double check this. It may be
> that this is an optional dependancy and this has been discussed and that
> may be OK. I’m reasonably sure it can’t be re-licensed under Apache.
> However I don’t know enough about your project to know the exact
> particulars or the code in question.
>
> The source release is missing a DISCLAIMER file [4]
>
> Other minor issues:
>
> 2 files are missing apache headers:
>
> ./samoa-0.3.0-incubating/samoa-test/src/test/java/org/apache/samoa/TestParams.java
>
> ./samoa-0.3.0-incubating/samoa-threads/src/main/java/org/apache/samoa/LocalThreadsDoTask.java
>
> You may want to change the NOTICE so it says “Apache Samoa (incubating)”
> rather than "Apache SAMOA". The disclaimer in the NOTICE file is a little
> unusual (See [5] for a simple NOTICE file) as only things that are actually
> bundled in the distribution need to be mentioned in LICENSE or NOTICE. [2]
> Or files that have copyright headers changed but again I’m reasonable sure
> you can’t change GPL code to be Apache licensed as you’re removed the
> copyleft provision that the GPL license granted.
>
> This line:
> public static final String copyrightNotice = "Copyright Yahoo! Inc 2013”;
>
> In:
> ./samoa-api/src/main/java/org/apache/samoa/core/Globals.java
>
> Is probably not correct. Although you may want to list Yahoo in the NOTICE
> file as the original developers of the software (again see [5] for example).
>
> Thanks,
> Justin
>
> 1. http://incubator.apache.org/guides/releasemanagement.html#check-list
> (see 3.6)
> 2. http://www.apache.org/dev/licensing-howto.html#guiding-principle
> 3. http://www.apache.org/legal/resolved.html#category-x
> 4. http://incubator.apache.org/guides/releasemanagement.html#check-list
> (see 3.1)
> 5. http://www.apache.org/dev/licensing-howto.html#simple

Re: [VOTE] SAMOA 0.3.0 (incubating) RC0

[Justin Mclean <ju...@classsoftware.com>]

Hi,

Also forgot to mention that there’s a few different non ASF copyrights:

 Copyright (C) 2013 University of Porto, Portugal
 Copyright (C) 2014 University of Porto, Portugal
 Copyright (C) 2013 - 2014 Yahoo! Inc.
 Copyright (C) 2013 Yahoo! Inc.
 Copyright (c) 2013 Yahoo! Inc. All Rights Reserved.
 Copyright (C) 2013 - 2014 Yahoo! Inc.

A few author tags:

If this is the case (i.e. the files with these copyrights haven’t been donated) then I’d expect them to be mentioned in NOTICE or possible LICENSE.

Thanks,
Justin

Re: [VOTE] SAMOA 0.3.0 (incubating) RC0

[Justin Mclean <ju...@classsoftware.com>]

Hi,

Hope you don’t mind the intrustion but I thought I’d take a look at your RC. As I only have a limited knowledge of your project I may of got a few things wrong.

There's a couple of things I would consider blockers if it was put to a vote on the IPMC list.

There is a jar in the source release:
./samoa-0.3.0-incubating/bin/s4-build/gradle-wrapper-1.4.jar

Having a jar in a source release is not possible. [1] This exact issue has come up on the incubator before you might want to search for it and see how it was resolved by other projects.

From what I can see MOA is under GPL which is a category X license not an Apache compatable license [3] You may want to double check this. It may be that this is an optional dependancy and this has been discussed and that may be OK. I’m reasonably sure it can’t be re-licensed under Apache. However I don’t know enough about your project to know the exact particulars or the code in question.

The source release is missing a DISCLAIMER file [4]

Other minor issues:

2 files are missing apache headers:
  ./samoa-0.3.0-incubating/samoa-test/src/test/java/org/apache/samoa/TestParams.java
  ./samoa-0.3.0-incubating/samoa-threads/src/main/java/org/apache/samoa/LocalThreadsDoTask.java

You may want to change the NOTICE so it says “Apache Samoa (incubating)” rather than "Apache SAMOA". The disclaimer in the NOTICE file is a little unusual (See [5] for a simple NOTICE file) as only things that are actually bundled in the distribution need to be mentioned in LICENSE or NOTICE. [2] Or files that have copyright headers changed but again I’m reasonable sure you can’t change GPL code to be Apache licensed as you’re removed the copyleft provision that the GPL license granted.

This line:
public static final String copyrightNotice = "Copyright Yahoo! Inc 2013”;

In:
./samoa-api/src/main/java/org/apache/samoa/core/Globals.java

Is probably not correct. Although you may want to list Yahoo in the NOTICE file as the original developers of the software (again see [5] for example).

Thanks,
Justin

1. http://incubator.apache.org/guides/releasemanagement.html#check-list (see 3.6)
2. http://www.apache.org/dev/licensing-howto.html#guiding-principle
3. http://www.apache.org/legal/resolved.html#category-x
4. http://incubator.apache.org/guides/releasemanagement.html#check-list (see 3.1)
5. http://www.apache.org/dev/licensing-howto.html#simple