[GitHub] [geode-benchmarks] pivotal-jbarrett commented on a change in pull request #129: TLS SNI support via "withSniProxy" Option

[GitBox <gi...@apache.org>]

pivotal-jbarrett commented on a change in pull request #129:
URL: https://github.com/apache/geode-benchmarks/pull/129#discussion_r436179998



##########
File path: geode-benchmarks/build.gradle
##########
@@ -23,16 +23,29 @@ version '1.0-SNAPSHOT'
 sourceCompatibility = 1.8
 
 def outputDir = project.hasProperty('outputDir') ? project.findProperty('outputDir') : new File(project.buildDir, "benchmarks_" + getDate()).getAbsolutePath()
-def geodeVersion = project.hasProperty('geodeVersion') ? project.findProperty('geodeVersion') : '1.+'
+def geodeVersion = project.hasProperty('geodeVersion') ? project.findProperty('geodeVersion') : '1.13.+'

Review comment:
       This will actually pin to 1.13.x not 1.13+. Just leave this change out. There are some combinations that don't work with some versions of Geode anyway.

##########
File path: geode-benchmarks/src/main/java/org/apache/geode/benchmark/parameters/HeapParameters.java
##########
@@ -28,7 +28,7 @@
   public static void configure(final TestConfig testConfig) {
     final String heap = System.getProperty("withHeap", "8g");
     logger.info("Configuring heap parameters {}.", heap);
-    configureAll(testConfig, "-Xmx" + heap, "-Xms" + heap);
+    configureGeodeProductJvms(testConfig, "-Xmx" + heap, "-Xms" + heap);

Review comment:
       I wonder if the work "product" is a bit redundant.

##########
File path: geode-benchmarks/build.gradle
##########
@@ -23,16 +23,29 @@ version '1.0-SNAPSHOT'
 sourceCompatibility = 1.8
 
 def outputDir = project.hasProperty('outputDir') ? project.findProperty('outputDir') : new File(project.buildDir, "benchmarks_" + getDate()).getAbsolutePath()
-def geodeVersion = project.hasProperty('geodeVersion') ? project.findProperty('geodeVersion') : '1.+'
+def geodeVersion = project.hasProperty('geodeVersion') ? project.findProperty('geodeVersion') : '1.13.+'
 
 def getDate() {
   new Date().format('yyyyMMddHHmmss')
 }
 
 
 repositories {
+  // in CI we want to search mavenLocal for geode
   mavenLocal()
-  mavenCentral()
+  // non-geode stuff can come from mavenCentral
+  mavenCentral() {
+    content {
+      excludeGroup 'org.apache.geode'
+    }
+  }
+  // when developing this project, use Geode develop branch snapshot
+  maven {
+    url "https://maven.apachegeode-ci.info/snapshots"
+    content {
+      includeGroup 'org.apache.geode'
+    }
+  }

Review comment:
       This is resolved by mavenLocal. The scripts will build any version of geode and put it in the local repo. Again revert this change.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org