Re: Again on the UPnP and Event Admin service

[Francesco Furfari <fr...@isti.cnr.it>]

Hi Karl,
sorry to answer you so late.
Anyway I  full tested the code and it works properly.
I saw you use both the keys in the PostEvent message (UPnP.device.id and 
upnp.deviceId)  and I agree with you.
I've written  a simple test code that allows to register and update EH 
graphically.
At the moment you find it in my sandbox, I have still to understand how 
to develop test case in mvn\Osgi, Marcel is working on it.
So I'm going to close the issue.
regards
    francesco

ps:
again 4-3 ?  ;-)


Francesco Furfari wrote:
> Hi Karl,
> I  was disconnected this weekend.
> I will try some test this evening or  tomorrow
> ... of course my tests were erroneously based on the old keys too :-D
>
> francesco
>
>
>
> Karl Pauls wrote:
>>>  remind me to offer a beer next time you come in Italy ;-)
>>
>> I look forward to it :-)
>>
>>> What I've realized is that EA subscriptions are limited respect the
>>> tracking possibilities offered by the UPnP spec.
>>
>> I just realized that there is another problem with this. The spec
>> requires that the events are published with upnp.serviceId and
>> upnp.deviceId keys... it follows that our approach with the filters
>> will not work because "upnp.serviceId" != UPnPService.ID and
>> "upnp.deviceId" != UPnPDevice.ID. I will commit a patch shortly that
>> fixes this by replacing all occurrences of mentioned keys in an
>> EventHandler filter with its UPnP counterpart. That way it should work
>> again. Would be great if you could test it sometime soon.
>>
>>> thanks
>>> francesco
>>
>> regards,
>>
>> Karl
>

Re: Again on the UPnP and Event Admin service

[Dennis Geurts <de...@luminis.nl>]

  <reporting>
    <plugins>
      ...
      <plugin>
        <artifactId>maven-surefire-plugin</artifactId>
      </plugin>
    </plugins>
  </reporting>


On Mon, 2006-07-03 at 12:34 +0200, Marcel Offermans wrote:

> On Jul 3, 2006, at 12:19 , Francesco Furfari wrote:
> 
> > I have still to understand how to develop test case in mvn\Osgi,  
> > Marcel is working on it.
> 
> If it's a plain junit test, you can just stick it in the src/test/ 
> java folder and it will be picked up by the test framework (if you  
> run mvn test or some target that indirectly invokes the tests).
> 
> The only problem I have with these tests is that they're not yet  
> automatically included in the generated website, but that's just my  
> inexperience with Maven and I'm sure that will be fixed soon.
> 
> For "integration tests" I want to create a new Maven plugin that will  
> launch an OSGi framework and perform some tests. There might be  
> something we can use from the Knopflerfish project there (they have  
> such a framework).
> 
> Greetings, Marcel
> 





Dennis Geurts

luminis®  

___________________________________

m: +31 (0) 612 078236
e: dennis.geurts@luminis.nl
i: www.luminis.nl 
___________________________________

 

Re: Again on the UPnP and Event Admin service

[Marcel Offermans <ma...@luminis.nl>]

On Jul 3, 2006, at 13:23 , Francesco Furfari wrote:

> in my case they aren't junit tests. I would be too complicated so  
> far, but I agree that we need a plugin that launches the framework  
> with the possibility to configure the bundles to install.  
> Unfortunately in our case (UPnP) it is not always sufficient, as  
> some times we should launch external devices too, so automating the  
> tests is not so trivial :(

Creating a plugin to start the framework, install a specific set of  
bundles and run some tests would be the first step. With this in  
place we could then perhaps add bundles to simulate specific devices  
for even more advanced testing scenarios. However, I think we should  
avoid depending on specific, physical hardware for any of the  
automated tests because those would never be available on a  
continuous build server.

Greetings, Marcel

Re: Again on the UPnP and Event Admin service

[Francesco Furfari <fr...@isti.cnr.it>]

Hi Marcel,
in my case they aren't junit tests. I would be too complicated so far, 
but I agree that we need a plugin that launches the framework with the 
possibility to configure the bundles to install. Unfortunately in our 
case (UPnP) it is not always sufficient, as some times we should launch 
external devices too, so automating the tests is not so trivial :(

ciao
francesco


Marcel Offermans wrote:
> On Jul 3, 2006, at 12:19 , Francesco Furfari wrote:
>
>> I have still to understand how to develop test case in mvn\Osgi, 
>> Marcel is working on it.
>
> If it's a plain junit test, you can just stick it in the src/test/java 
> folder and it will be picked up by the test framework (if you run mvn 
> test or some target that indirectly invokes the tests).
>
> The only problem I have with these tests is that they're not yet 
> automatically included in the generated website, but that's just my 
> inexperience with Maven and I'm sure that will be fixed soon.
>
> For "integration tests" I want to create a new Maven plugin that will 
> launch an OSGi framework and perform some tests. There might be 
> something we can use from the Knopflerfish project there (they have 
> such a framework).
>
> Greetings, Marcel
>

Re: Again on the UPnP and Event Admin service

[Marcel Offermans <ma...@luminis.nl>]

On Jul 3, 2006, at 12:19 , Francesco Furfari wrote:

> I have still to understand how to develop test case in mvn\Osgi,  
> Marcel is working on it.

If it's a plain junit test, you can just stick it in the src/test/ 
java folder and it will be picked up by the test framework (if you  
run mvn test or some target that indirectly invokes the tests).

The only problem I have with these tests is that they're not yet  
automatically included in the generated website, but that's just my  
inexperience with Maven and I'm sure that will be fixed soon.

For "integration tests" I want to create a new Maven plugin that will  
launch an OSGi framework and perform some tests. There might be  
something we can use from the Knopflerfish project there (they have  
such a framework).

Greetings, Marcel