You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucenenet.apache.org by "tohidemyname (via GitHub)" <gi...@apache.org> on 2024/06/05 00:46:08 UTC
[PR] ShingleFilter produces invalid queries [lucenenet]
tohidemyname opened a new pull request, #946:
URL: https://github.com/apache/lucenenet/pull/946
<!-- Thank you for submitting a pull request to our repo. -->
<!-- Please do NOT submit PRs for features in newer versions of Lucene. We should keep the target version consistent across our repository to make the upgrade process to newer versions of Lucene go smoothly. -->
<!-- If this is your first PR in the Lucene.NET repo, please run through the checklist
below to ensure a smooth review and merge process for your PR. -->
- [x] You've read the [Contributor Guide](https://github.com/apache/lucenenet/blob/main/CONTRIBUTING.md) and [Code of Conduct](https://www.apache.org/foundation/policies/conduct.html).
- [x] You've included unit or integration tests for your change, where applicable.
- [x] You've included inline docs for your change, where applicable.
- [x] There's an open issue for the PR that you are making. If you'd like to propose a change, please [open an issue](https://github.com/apache/lucenenet/issues/new/choose) to discuss the change or find an existing issue.
<!-- Once all that is done, you're ready to go. Open the PR with the content below. -->
Summary of the changes (Less than 80 chars)
Fixes #{bug number} (in this specific format)
https://github.com/apache/lucenenet/issues/943
## Description
{Detail}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ShingleFilter produces invalid queries [lucenenet]
Posted by "paulirwin (via GitHub)" <gi...@apache.org>.
paulirwin commented on PR #946:
URL: https://github.com/apache/lucenenet/pull/946#issuecomment-2430471707
@tohidemyname Thanks, also, for this PR!
This appears to be a fairly faithful port of this fix in Lucene 6.5: https://github.com/apache/lucene/commit/57a42e4ec54aebac40c1ef7dc93d933cd00dbe1e
Just like #947, we'll need to polish a couple things to our conventions like the test name. I'll do that work as part of merging.
cc @NightOwl888
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ShingleFilter produces invalid queries [lucenenet]
Posted by "paulirwin (via GitHub)" <gi...@apache.org>.
paulirwin merged PR #946:
URL: https://github.com/apache/lucenenet/pull/946
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org