You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by pdxrunner <gi...@git.apache.org> on 2016/09/21 16:55:19 UTC

[GitHub] incubator-geode pull request #244: Feature/geode-1128-2

GitHub user pdxrunner opened a pull request:

    https://github.com/apache/incubator-geode/pull/244

    Feature/geode-1128-2

    Added a section to the output of the gfsh command show missing-disk-stores to list any missing colocated regions
    See review: https://reviews.apache.org/r/52052/ 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/pdxrunner/incubator-geode feature/GEODE-1128-2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-geode/pull/244.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #244
    
----
commit 660f79fa70b8232d73e54ca8cf1fa2c666095538
Author: Ken Howe <kh...@pivotal.io>
Date:   2016-09-19T18:57:58Z

    GEODE-1128: Enhance missing-disk-stores command with missing regions
    
    Refactored \u201cshow missing-disk-stores command\u201d and added a section to the
    output to show missing colocated regions. Corrected messages in
    LocalizedStrings, change \u201cgemfire list-missing-disk-stores\u201d to
    \u201cgfsh show missing-disk-stores\u201d. Added new command function class to gather
    both missing disk-store and missing colocated region information on a
    distributed system member.
    
    Parameterized show missing-disk-store error message.
    
    Added new DataSerializable class for sending missing colocated region
    results to gfsh command.
    
    Refactored ColocationLogger. Class originally deferred updating the list
    of missing colocated children (i.e. removing regions from the missing
    list that are now present) for a region until the next logging
    interval. This has been changed to update the list on-demand, whenever
    getMissingChildRegions() is called.
    
    Added DUnit test for new functionality in show missing-disk-store
    command.
    
    Added JUnit tests for new classes

commit 09aaa8a2a59b38aa36e2f0def4706387f1506012
Author: Ken Howe <kh...@pivotal.io>
Date:   2016-09-21T16:24:36Z

    GEODE-1128: Rename method to be more descriptive of functionality

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-geode issue #244: Feature/geode-1128-2

Posted by dschneider-pivotal <gi...@git.apache.org>.
Github user dschneider-pivotal commented on the issue:

    https://github.com/apache/incubator-geode/pull/244
  
    looks good, I will pull it in


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-geode pull request #244: Feature/geode-1128-2

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-geode/pull/244


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---