You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openoffice.apache.org by bu...@apache.org on 2013/07/25 17:41:39 UTC
[Bug 122840] New: Ranged names don't work anymore
https://issues.apache.org/ooo/show_bug.cgi?id=122840
Bug ID: 122840
Issue Type: DEFECT
Summary: Ranged names don't work anymore
Product: Calc
Version: AOO 4.0.0
Hardware: PC
OS: Linux64
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: programming
Assignee: issues@openoffice.apache.org
Reporter: franky.chambers@yahoo.fr
CC: issues@openoffice.apache.org
Created attachment 81143
--> https://issues.apache.org/ooo/attachment.cgi?id=81143&action=edit
Spreadsheet to compute different parameters of an electric vehicle.
Names in my spreadsheet don't work anymore with OOO 4.0.
See attachement.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
[Bug 122840] Ranged names don't work anymore
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122840
--- Comment #7 from Ariel Constenla-Haile <ar...@apache.org> ---
(In reply to Regina Henschel from comment #6)
> @Ariel: It is OK in r1378069, it is broken in r1381583.
Then might be introduced by revision 1379349 - bug 120478 "Enhancement request:
support sheet scoped named ranges in Calc"
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
[Bug 122840] Ranged names don't work anymore
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122840
Ariel Constenla-Haile <ar...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|REOPENED |RESOLVED
Resolution|--- |FIXED
--- Comment #27 from Ariel Constenla-Haile <ar...@apache.org> ---
back to fixed
--
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
[Bug 122840] Ranged names don't work anymore
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122840
--- Comment #4 from Edwin Sharp <el...@mail-page.com> ---
Created attachment 81146
--> https://issues.apache.org/ooo/attachment.cgi?id=81146&action=edit
2.4.3 vs. 4.0.0 screenshot
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
[Bug 122840] Ranged names don't work anymore
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122840
Ariel Constenla-Haile <ar...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |regression
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
[Bug 122840] Ranged names don't work anymore
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122840
Clarence GUO <cl...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |clarence.guo.bj@gmail.com
--- Comment #14 from Clarence GUO <cl...@gmail.com> ---
Hi~ I find a problem in 120478 which cause this defect.
In 120478, zhaoshzh added support for scope of name range. MS Excel can define
a same name to a range on different sheets. For example defines "MyRange" to
"Sheet1.A1:A4" with scope in sheet1 and defines "MyRange" again to
"Sheet2.A1:A4" with scope in sheet2.
In order to add this support, he changed code in ScXMLImport::SetNamedRanges(),
from
xNamedRanges->addNewByName((*aItr)->sName, sTempContent, aCellAddress,
GetRangeType((*aItr)->sRangeType));
to
xNamedRanges->addNewByScopeName( sTabName, (*aItr)->sName, (*aItr)->sContent,
aCellAddress, GetRangeType((*aItr)->sRangeType) );
addNewByScopeName is a new method, the difference with addNewByName is it added
a new parameter sTabName in order to distinguish the scope. Others are same.
But note he also changed the third parameter of the new method. In the old
method, that parameter is sTempContent, it is string "0". However, in the new
method he passed (*aItr)->sContent into, (*aItr)->sContent is the real content
of the name. For example, for above illustration, "Sheet1.A1:A4" is the content
of range name "MyRange".
I'm not sure whether it is his pen mistake, but from logic, as he only add a
new parameter for scope identification, the old parameters should not be
changed. So I just change (*aItr)->sContent back to sTempContent, then it
works.
And there's no problem on 120478 sample file with the fix. I did some test,
haven't find problem.
But I don't know why we need to pass a "0" string as content into the method.
Does anybody knows that?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
[Bug 122840] Ranged names don't work anymore
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122840
--- Comment #26 from Ariel Constenla-Haile <ar...@apache.org> ---
(In reply to Prachi from comment #25)
> This defect is not fixed in 4.0.1 Rev. 1518667 .
> OS -Win 7.
> Spreadsheet still shows #NAME? and no graph with Rev. 1518667
Per comment 23 this should be fixed with revision 1519400
1518667 < 1519400
--
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
[Bug 122840] Ranged names don't work anymore
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122840
Oliver-Rainer Wittmann <or...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ACCEPTED |RESOLVED
Resolution|--- |FIXED
Target Milestone|--- |4.0.1
--- Comment #22 from Oliver-Rainer Wittmann <or...@apache.org> ---
fixed on trunk and branch AOO401 (rev. 1519400)
--
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
[Bug 122840] Ranged names don't work anymore
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122840
Ariel Constenla-Haile <ar...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |rb.henschel@t-online.de
--- Comment #3 from Ariel Constenla-Haile <ar...@apache.org> ---
Ccing Regina
@Regine: you seem to have older revisions, can check this as you did with Bug
122822? Thanks!
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
[Bug 122840] Ranged names don't work anymore
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122840
--- Comment #10 from Oliver-Rainer Wittmann <or...@apache.org> ---
I am having a deeper look.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
[Bug 122840] Ranged names don't work anymore
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122840
don1225 <do...@leckieinc.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |don@leckieinc.com
--- Comment #9 from don1225 <do...@leckieinc.com> ---
Created attachment 81197
--> https://issues.apache.org/ooo/attachment.cgi?id=81197&action=edit
Zip file containing many examples.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
[Bug 122840] Ranged names don't work anymore
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122840
Oliver-Rainer Wittmann <or...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|CONFIRMED |ACCEPTED
Assignee|issues@openoffice.apache.or |orw@apache.org
|g |
--- Comment #19 from Oliver-Rainer Wittmann <or...@apache.org> ---
taking over to integrate the fix into trunk and into branch AOO401 (if release
blocker flag is granted.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
[Bug 122840] Ranged names don't work anymore
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122840
Oliver-Rainer Wittmann <or...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #81430|review? |review+
Flags| |
CC| |orw@apache.org
--- Comment #18 from Oliver-Rainer Wittmann <or...@apache.org> ---
Comment on attachment 81430
--> https://issues.apache.org/ooo/attachment.cgi?id=81430
Fix patch
patch looks good.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
[Bug 122840] Ranged names don't work anymore
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122840
fanyuzhen@gmail.com changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |fanyuzhen@gmail.com
--- Comment #24 from fanyuzhen@gmail.com ---
The latest available build in cwiki is AOO401m2(Build:9711) - Rev. 1518667,
waiting for the build AOO401 (rev. 1519400)
--
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
[Bug 122840] Ranged names don't work anymore
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122840
Prachi <pr...@yahoo.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |REOPENED
Resolution|FIXED |---
--- Comment #25 from Prachi <pr...@yahoo.com> ---
This defect is not fixed in 4.0.1 Rev. 1518667 .
OS -Win 7.
Spreadsheet still shows #NAME? and no graph with Rev. 1518667
--
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
review granted: [Bug 122840] Ranged names don't work anymore :
[Attachment 81430] Fix patch
Posted by bu...@apache.org.
Oliver-Rainer Wittmann <or...@apache.org> has granted Clarence GUO
<cl...@gmail.com>'s request for review:
Bug 122840: Ranged names don't work anymore
https://issues.apache.org/ooo/show_bug.cgi?id=122840
Attachment 81430: Fix patch
https://issues.apache.org/ooo/attachment.cgi?id=81430&action=edit
------- Additional Comments from Oliver-Rainer Wittmann <or...@apache.org>
patch looks good.
[Bug 122840] Ranged names don't work anymore
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122840
--- Comment #20 from SVN Robot <sv...@dev.null.org> ---
"orw" committed SVN revision 1519366 into trunk:
122840: <ScXMLImport::SetNamedRanges()> - adding named ranges with temporary
...
--
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
[Bug 122840] Ranged names don't work anymore
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122840
--- Comment #5 from Ariel Constenla-Haile <ar...@apache.org> ---
(In reply to Edwin Sharp from comment #4)
> Created attachment 81146 [details]
> 2.4.3 vs. 4.0.0 screenshot
this is a regression from 3.4.1 to 4.0.0
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
[Bug 122840] Ranged names don't work anymore
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122840
--- Comment #6 from Regina Henschel <rb...@t-online.de> ---
@Ariel: It is OK in r1378069, it is broken in r1381583.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
[Bug 122840] Ranged names don't work anymore
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122840
Clarence GUO <cl...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #81430| |review?
Flags| |
--- Comment #17 from Clarence GUO <cl...@gmail.com> ---
Created attachment 81430
--> https://issues.apache.org/ooo/attachment.cgi?id=81430&action=edit
Fix patch
Root cause and fix analysis please reference my previous comment
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
4.0.1_release_blocker requested: [Bug 122840] Ranged names don't
work anymore
Posted by bu...@apache.org.
Oliver-Rainer Wittmann <or...@apache.org> has asked for 4.0.1_release_blocker:
Bug 122840: Ranged names don't work anymore
https://issues.apache.org/ooo/show_bug.cgi?id=122840
------- Additional Comments from Oliver-Rainer Wittmann <or...@apache.org>
fix available
[Bug 122840] Ranged names don't work anymore
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122840
--- Comment #11 from Oliver-Rainer Wittmann <or...@apache.org> ---
(In reply to Oliver-Rainer Wittmann from comment #10)
> I am having a deeper look.
I had no success in my defect cause hunting.
Thus, please somebody else step in
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
[Bug 122840] Ranged names don't work anymore
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122840
fanyuzhen@gmail.com changed:
What |Removed |Added
----------------------------------------------------------------------------
QA Contact| |prachi27jain@yahoo.com
--
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
[Bug 122840] Ranged names don't work anymore
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122840
--- Comment #15 from Oliver-Rainer Wittmann <or...@apache.org> ---
(In reply to Clarence GUO from comment #14)
>
> [snip]
>
> I'm not sure whether it is his pen mistake, but from logic, as he only add a
> new parameter for scope identification, the old parameters should not be
> changed. So I just change (*aItr)->sContent back to sTempContent, then it
> works.
> And there's no problem on 120478 sample file with the fix. I did some test,
> haven't find problem.
> But I don't know why we need to pass a "0" string as content into the
> method. Does anybody knows that?
That is the defect cause and the solution as well.
Applying "0" as content when adding a named range is done by purpose as far as
I can see from the code in <ScXMLImport::SetNamedRanges()>. There two loops in
this methods. The first inserts the named ranges. The second applies the
content incl. the grammar to the inserted ranges. Thus, I conclude that it is
done by purpose.
I also agree to your conclusion that by bug 120478 only the <scope name> has
been added for the insertion of the named ranges.
Please contribute the corresponding patch
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
[Bug 122840] Ranged names don't work anymore
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122840
jsc@apache.org changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jsc@apache.org
Flags|4.0.1_release_blocker? |4.0.1_release_blocker+
--- Comment #21 from jsc@apache.org ---
approve showstopper request
--
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
[Bug 122840] Ranged names don't work anymore
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122840
--- Comment #13 from Joe Smith <je...@martnet.com> ---
> The attached file is far too large and complex. It cannot be analyzed
> in a reasonable time. Please provide a much smaller file, that shows the error
I provided a small sample document and steps for reproducing the problem under
bug 122886
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
4.0.1_release_blocker granted: [Bug 122840] Ranged names don't work
anymore
Posted by bu...@apache.org.
jsc@apache.org has granted Oliver-Rainer Wittmann <or...@apache.org>'s request
for 4.0.1_release_blocker:
Bug 122840: Ranged names don't work anymore
https://issues.apache.org/ooo/show_bug.cgi?id=122840
------- Additional Comments from jsc@apache.org
approve showstopper request
[Bug 122840] Ranged names don't work anymore
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122840
--- Comment #12 from Regina Henschel <rb...@t-online.de> ---
I was not able to produce such error with a new spreadsheet. The named
expressions with ADDRESS, INDIRECT, and VLOOKUP work in my spreadsheet.
The attached file is far too large and complex. It cannot be analyzed in a
reasonable time. Please provide a much smaller file, that shows the error.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
[Bug 122840] Ranged names don't work anymore
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122840
Ariel Constenla-Haile <ar...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jes@martnet.com
--- Comment #8 from Ariel Constenla-Haile <ar...@apache.org> ---
*** Bug 122886 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
review requested: [Bug 122840] Ranged names don't work anymore :
[Attachment 81430] Fix patch
Posted by bu...@apache.org.
Clarence GUO <cl...@gmail.com> has asked for review:
Bug 122840: Ranged names don't work anymore
https://issues.apache.org/ooo/show_bug.cgi?id=122840
Attachment 81430: Fix patch
https://issues.apache.org/ooo/attachment.cgi?id=81430&action=edit
------- Additional Comments from Clarence GUO <cl...@gmail.com>
Root cause and fix analysis please reference my previous comment
[Bug 122840] Ranged names don't work anymore
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122840
Oliver-Rainer Wittmann <or...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags| |4.0.1_release_blocker?
--- Comment #16 from Oliver-Rainer Wittmann <or...@apache.org> ---
fix available
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
[Bug 122840] Ranged names don't work anymore
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122840
--- Comment #23 from SVN Robot <sv...@dev.null.org> ---
"orw" committed SVN revision 1519400 into branches/AOO401:
122840: <ScXMLImport::SetNamedRanges()> - adding named ranges with temporary
...
--
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
[Bug 122840] Ranged names don't work anymore
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122840
Prachi <pr...@yahoo.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |VERIFIED
--
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
[Bug 122840] Ranged names don't work anymore
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122840
brinzing <ol...@gmx.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |oliver.brinzing@gmx.de
--- Comment #2 from brinzing <ol...@gmx.de> ---
confirming, looks good in aoo3.4.1 but show #NAME? in aoo 4.0
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
[Bug 122840] Ranged names don't work anymore
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122840
Edwin Sharp <el...@mail-page.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |CONFIRMED
CC| |elish@mail-page.com
Ever confirmed|0 |1
--- Comment #1 from Edwin Sharp <el...@mail-page.com> ---
Attachment displays OK in OOo 2.4.3.
Attachment shows #NAME? and no graph with Rev. 1503704 Win 7.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
[Bug 122840] Ranged names don't work anymore
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122840
Ariel Constenla-Haile <ar...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Hardware|PC |All
OS|Linux64 |All
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.