[GitHub] [iceberg] aokolnychyi commented on a diff in pull request #8571: Spark 3.5: Initial support

["aokolnychyi (via GitHub)" <gi...@apache.org>]

aokolnychyi commented on code in PR #8571:
URL: https://github.com/apache/iceberg/pull/8571#discussion_r1328954186


##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/sql/TestStoragePartitionedJoins.java:
##########
@@ -489,11 +489,9 @@ public void testJoinsWithOneSplitTables() {
 
     sql("INSERT INTO %s VALUES (1L, 100, 'software')", tableName(OTHER_TABLE_NAME));
 
-    // Spark should be able to avoid shuffles even without SPJ if each side has only one split

Review Comment:
   The remaining shuffle is a global sort to order the results. Also, Spark starts to prefer the parallelism and now inserts shuffles even with 1 split.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org