You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@curator.apache.org by cammckenzie <gi...@git.apache.org> on 2014/11/19 07:23:23 UTC

[GitHub] curator pull request: CURATOR-167 - Partial fix to clean up Curato...

GitHub user cammckenzie opened a pull request:

    https://github.com/apache/curator/pull/55

    CURATOR-167 - Partial fix to clean up Curator managed watch objects

    CURATOR-167 - Partial fix to clean up Curator managed watch objects whenthe cache closes. A full fix requires the ability to cancel watches in ZK which is not available until ZK 3.5

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/curator CURATOR-167

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/curator/pull/55.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #55
    
----
commit 44c3891e3e1633e456c530165513fff50a52a8b4
Author: Cameron McKenzie <ca...@unico.com.au>
Date:   2014-11-19T03:23:24Z

    CURATOR-167 - Partial fix to clean up Curator managed watch objects when
    the cache closes. A full fix requires the ability to cancel watches in
    ZK which is not available until ZK 3.5

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] curator pull request: CURATOR-167 - Partial fix to clean up Curato...

Posted by dragonsinth <gi...@git.apache.org>.
Github user dragonsinth commented on the pull request:

    https://github.com/apache/curator/pull/55#issuecomment-63698639
  
    It looks like TreeCache might be fine here.
    ```
    TreeCache.close() -> TreeCacheNode.wasDeleted() [recursively] -> client.clearWatcherReferences(this)
    ```



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Re: [GitHub] curator pull request: CURATOR-167 - Partial fix to clean up Curato...

Posted by Cameron McKenzie <mc...@gmail.com>.
I don't think path children cache does, I think that tree cache may, will
have a look tomorrow
On Nov 19, 2014 5:35 PM, "dragonsinth" <gi...@git.apache.org> wrote:

> Github user dragonsinth commented on the pull request:
>
>     https://github.com/apache/curator/pull/55#issuecomment-63598493
>
>     BTW: do PathChildrenCache and TreeCache have similar issues?
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>

[GitHub] curator pull request: CURATOR-167 - Partial fix to clean up Curato...

Posted by dragonsinth <gi...@git.apache.org>.
Github user dragonsinth commented on the pull request:

    https://github.com/apache/curator/pull/55#issuecomment-63598493
  
    BTW: do PathChildrenCache and TreeCache have similar issues?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] curator pull request: CURATOR-167 - Partial fix to clean up Curato...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/curator/pull/55


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] curator pull request: CURATOR-167 - Partial fix to clean up Curato...

Posted by cammckenzie <gi...@git.apache.org>.
Github user cammckenzie commented on the pull request:

    https://github.com/apache/curator/pull/55#issuecomment-63597770
  
    No unit tests yet, couldn't think of a good way of testing without having a test that ran for a long time. I guess an option is to look at the size of the watcher cache, but it's not super accessible (I guess you could get at it with some reflection shenanigans).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] curator pull request: CURATOR-167 - Partial fix to clean up Curato...

Posted by cammckenzie <gi...@git.apache.org>.
Github user cammckenzie commented on the pull request:

    https://github.com/apache/curator/pull/55#issuecomment-63719163
  
    Yep, I think you're right, should be ok.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---