[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #1447: Fix bug that BE crashes when inserting null value to non-nullable columns

[GitBox <gi...@apache.org>]

EmmyMiao87 commented on a change in pull request #1447: Fix bug that BE crashes when inserting null value to non-nullable columns
URL: https://github.com/apache/incubator-doris/pull/1447#discussion_r301443551
 
 

 ##########
 File path: be/src/exec/olap_table_sink.cpp
 ##########
 @@ -640,14 +640,25 @@ void OlapTableSink::_convert_batch(RuntimeState* state, RowBatch* input_batch, R
 #else
                     state->append_error_msg_to_file("", ss.str());
 
 Review comment:
   please add filtered_rows++;

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@doris.apache.org
For additional commands, e-mail: dev-help@doris.apache.org