You are viewing a plain text version of this content. The canonical link for it is here.
Posted to apreq-dev@httpd.apache.org by "Philip M. Gollucci" <pg...@p6m7g8.com> on 2005/07/12 20:16:57 UTC

Re: svn commit: r215984 - in /httpd/apreq/trunk: ./ module/apache/ module/apache2/

Hi,

I followed most of that:

What does this do 
+
+    ap_add_version_component(p, apr_psprintf(p,
+                                             "mod_apreq2-%d/%s",
+                                             APREQ_APACHE2_MMN,
+                                             APREQ_VERSION_STRING));


Whats the point of adding an apache module magic number to our banner string ?

Defining an apreq mmn I get; That makes sense.






END 
---------------------------------------------------------
    What doesn't kill us can only make us stronger.
               Nothing is impossible.
				
Philip M. Gollucci (pgollucci@p6m7g8.com) 301.254.5198
Consultant / http://p6m7g8.net/Resume/resume.shtml
Senior Developer / Liquidity Services, Inc.
     http://www.liquidityservicesinc.com
        http://www.liquidation.com
        http://www.uksurplus.com
        http://www.govliquidation.com
        http://www.gowholesale.com



Re: svn commit: r215984 - in /httpd/apreq/trunk: ./ module/apache/ module/apache2/

Posted by Joe Schaefer <jo...@sunstarsys.com>.
"Philip M. Gollucci" <pg...@p6m7g8.com> writes:

> Hi,
>
> I followed most of that:
>
> What does this do +
> +    ap_add_version_component(p, apr_psprintf(p,
> +                                             "mod_apreq2-%d/%s",
> +                                             APREQ_APACHE2_MMN,
> +                                             APREQ_VERSION_STRING));
>
>
> Whats the point of adding an apache module magic number to our banner
> string ? 

The only reason I like adding the banner string is that it makes 
getting the version info easier for users.  Since there are two 
components we care about (mod_apreq2 and libapreq2), it makes 
sense to list them both somehow.

In fact, what I'm going to do is change that code to grab the
library version number at runtime.  That's more useful info.

-- 
Joe Schaefer