You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by "Vladimir Orlov (JIRA)" <ji...@apache.org> on 2008/08/14 12:21:44 UTC

[jira] Created: (BEANUTILS-326) Iterating by key/value pairs in Map in BeanUtilsBean.populate(...) method

Iterating by key/value pairs in Map in BeanUtilsBean.populate(...) method
-------------------------------------------------------------------------

                 Key: BEANUTILS-326
                 URL: https://issues.apache.org/jira/browse/BEANUTILS-326
             Project: Commons BeanUtils
          Issue Type: Improvement
          Components: Bean / Property Utils
    Affects Versions: 1.7.0
            Reporter: Vladimir Orlov
            Priority: Minor


I think that iterating by key/value pairs in Map should be done in more appropriate way than it is done currently: it takes set of keys, iterates by it and on each iteration cycle searchches for the value via Map.get(<key>) API. Consequently it does the search by key in map on every step and it should make the processign slower.

An alternative to such approach is to use Map.entrySet() API which returns the Set of key/value pairs (as instances of Map.Entry class). Using it eliminates the need to do a search by key (Map.get(...) API) in the map on each step of iteration and should work faster.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Resolved: (BEANUTILS-326) Iterating by key/value pairs in Map in BeanUtilsBean.populate(...) method

Posted by "Niall Pemberton (JIRA)" <ji...@apache.org>.

     [ https://issues.apache.org/jira/browse/BEANUTILS-326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Niall Pemberton resolved BEANUTILS-326.
---------------------------------------

       Resolution: Fixed
    Fix Version/s: 1.8.0
         Assignee: Niall Pemberton

Fixed, thanks for the suggestion:

http://svn.apache.org/viewvc?view=rev&revision=687117

> Iterating by key/value pairs in Map in BeanUtilsBean.populate(...) method
> -------------------------------------------------------------------------
>
>                 Key: BEANUTILS-326
>                 URL: https://issues.apache.org/jira/browse/BEANUTILS-326
>             Project: Commons BeanUtils
>          Issue Type: Improvement
>          Components: Bean / Property Utils
>    Affects Versions: 1.7.0
>            Reporter: Vladimir Orlov
>            Assignee: Niall Pemberton
>            Priority: Minor
>             Fix For: 1.8.0
>
>
> I think that iterating by key/value pairs in Map should be done in more appropriate way than it is done currently: it takes set of keys, iterates by it and on each iteration cycle searchches for the value via Map.get(<key>) API. Consequently it does the search by key in map on every step and it should make the processign slower.
> An alternative to such approach is to use Map.entrySet() API which returns the Set of key/value pairs (as instances of Map.Entry class). Using it eliminates the need to do a search by key (Map.get(...) API) in the map on each step of iteration and should work faster.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.