You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2023/01/04 14:06:01 UTC

[GitHub] [airflow] Taragolis commented on a diff in pull request #28631: Clear DB before individual module tests

Taragolis commented on code in PR #28631:
URL: https://github.com/apache/airflow/pull/28631#discussion_r1061516214


##########
tests/api/common/test_mark_tasks.py:
##########
@@ -49,7 +49,7 @@ def dagbag():
     from airflow.models.dagbag import DagBag
 
     # Ensure the DAGs we are looking at from the DB are up-to-date
-    non_serialized_dagbag = DagBag(read_dags_from_db=False, include_examples=False)
+    non_serialized_dagbag = DagBag(read_dags_from_db=False, include_examples=True)

Review Comment:
   Some API tests use example DAGs: `example_subdag_operator`, `example_trigger_target_dag` and others.
   Before changes in this PR all example serialised DAGs stored into database so we did not have issues with it but after we start cleanup DB before each module we have.
   
   I'd rather to say this is temporary solution as target we need to use DAGs from:
   - `tests/dags`
   - `tests/dags_corrupted`
   - `tests/dags_with_system_exit`
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org