You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/10/05 13:53:23 UTC
[GitHub] [airflow] Fortschritt69 opened a new pull request #11283: Refactor
Fortschritt69 opened a new pull request #11283:
URL: https://github.com/apache/airflow/pull/11283
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] drsantos20 commented on a change in pull request #11283: Refactor
Posted by GitBox <gi...@apache.org>.
drsantos20 commented on a change in pull request #11283:
URL: https://github.com/apache/airflow/pull/11283#discussion_r499791981
##########
File path: setup.py
##########
@@ -65,12 +64,6 @@ class CleanCommand(Command):
description = "Tidy up the project root"
user_options = [] # type: List[str]
- def initialize_options(self):
- """Set default values for options."""
-
- def finalize_options(self):
- """Set final values for options."""
-
Review comment:
why we removed this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on pull request #11283: Refactor
Posted by GitBox <gi...@apache.org>.
turbaszek commented on pull request #11283:
URL: https://github.com/apache/airflow/pull/11283#issuecomment-703738158
@Fortschritt69 can you comply with in your PR?
```
^ Add meaningful description above
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek edited a comment on pull request #11283: Refactor
Posted by GitBox <gi...@apache.org>.
turbaszek edited a comment on pull request #11283:
URL: https://github.com/apache/airflow/pull/11283#issuecomment-703738158
@Fortschritt69 can you comply with the following line in your PR?
```
^ Add meaningful description above
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil closed pull request #11283: Refactor
Posted by GitBox <gi...@apache.org>.
kaxil closed pull request #11283:
URL: https://github.com/apache/airflow/pull/11283
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org