[jira] [Commented] (HADOOP-11163) MetricsSystemImpl may miss a registered source

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-11163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14158902#comment-14158902 ] 

Hadoop QA commented on HADOOP-11163:
------------------------------------

{color:green}+1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12672892/HADOOP-11163.patch
  against trunk revision c8212ba.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-common-project/hadoop-common.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/4862//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/4862//console

This message is automatically generated.

> MetricsSystemImpl may miss a registered source
> ----------------------------------------------
>
>                 Key: HADOOP-11163
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11163
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: metrics
>    Affects Versions: 3.0.0
>            Reporter: Chuan Liu
>            Assignee: Chuan Liu
>            Priority: Minor
>         Attachments: HADOOP-11163.patch
>
>
> Calling to {{MetricsSystemImpl#register(String name, String desc, T source)}} could miss when the name is {{null}}. This is related to my previous change in HADOOP-11105.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)