You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by "PragmaTwice (via GitHub)" <gi...@apache.org> on 2023/04/04 13:45:32 UTC

[GitHub] [incubator-kvrocks] PragmaTwice opened a new pull request, #1368: Refactor Status to avoid large stack size in happy path

PragmaTwice opened a new pull request, #1368:
URL: https://github.com/apache/incubator-kvrocks/pull/1368

   Follow the implementation of Status in RocksDB, google absl, doris and more, we refactor the Status to make it just a pointer (8 instead of 40 for libstdc++ std::string).
   
   For happy path (OK status) with large probability, it benefits the performance.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] PragmaTwice merged pull request #1368: Refactor Status to avoid large stack size in happy path

Posted by "PragmaTwice (via GitHub)" <gi...@apache.org>.
PragmaTwice merged PR #1368:
URL: https://github.com/apache/incubator-kvrocks/pull/1368


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] PragmaTwice commented on pull request #1368: Refactor Status to avoid large stack size in happy path

Posted by "PragmaTwice (via GitHub)" <gi...@apache.org>.
PragmaTwice commented on PR #1368:
URL: https://github.com/apache/incubator-kvrocks/pull/1368#issuecomment-1496276594

   Yeah, I used to submit this patch in #1330, but there is always an ICE in gcc9 during LTO.
   It has been workarounded in d13dbfd2c0bab0cdc2bc4b3e8f512041b5173633, so this patch can be merged.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] tisonkun commented on pull request #1368: Refactor Status to avoid large stack size in happy path

Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #1368:
URL: https://github.com/apache/incubator-kvrocks/pull/1368#issuecomment-1496935329

   @PragmaTwice That's it! I browse the first page of closed PRs and don't find it. That said, what a large traffic in the community recently 🤣 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] tisonkun commented on pull request #1368: Refactor Status to avoid large stack size in happy path

Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #1368:
URL: https://github.com/apache/incubator-kvrocks/pull/1368#issuecomment-1496182419

   I remember I review a similar patch before, but I cannot find it now..
   
   Good to merge for this one.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] torwig commented on pull request #1368: Refactor Status to avoid large stack size in happy path

Posted by "torwig (via GitHub)" <gi...@apache.org>.
torwig commented on PR #1368:
URL: https://github.com/apache/incubator-kvrocks/pull/1368#issuecomment-1496190093

   @tisonkun Yeah, I also had a strong feeling of déjà vu.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org