[GitHub] [doris] HappenLee commented on a diff in pull request #20391: [refactor](profile) refactor the join profile when its shared hash table

["HappenLee (via GitHub)" <gi...@apache.org>]

HappenLee commented on code in PR #20391:
URL: https://github.com/apache/doris/pull/20391#discussion_r1216153361


##########
be/src/exec/exec_node.h:
##########
@@ -289,6 +290,13 @@ class ExecNode {
     //
     OpentelemetrySpan _span;
 
+    //NOTICE: now add a faker profile, because sometimes the profile record is useless
+    //so we want remove some counters and timers, eg: in join node, if it's broadcast_join
+    //and shared hash table, some counter/timer about build hash table is useless,
+    //so we could add those counter/timer in faker profile, and those will not display in web profile.
+    std::shared_ptr<RuntimeProfile> _faker_runtime_profile =

Review Comment:
   why use shared_ptr ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org