You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kyuubi.apache.org by GitBox <gi...@apache.org> on 2021/12/06 10:21:57 UTC

[GitHub] [incubator-kyuubi] murong00 opened a new pull request #1513: Added support liveness and readiness for kyuubi pod

murong00 opened a new pull request #1513:
URL: https://github.com/apache/incubator-kyuubi/pull/1513


   ### _Why are the changes needed?_
   It is better to support `livenessProbe` and `readinessProbe` for indicating whether the container is running.
   
   
   ### _How was this patch tested?_
   - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
   
   - [ ] Add screenshots for manual tests if appropriate
   
   - [x] [Run test](https://kyuubi.readthedocs.io/en/latest/develop_tools/testing.html#running-tests) locally before make a pull request
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-kyuubi] codecov-commenter commented on pull request #1513: Added support liveness and readiness for kyuubi pod

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1513:
URL: https://github.com/apache/incubator-kyuubi/pull/1513#issuecomment-986674024


   # [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1513?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1513](https://codecov.io/gh/apache/incubator-kyuubi/pull/1513?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6e7d7f0) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/542ceadcf30fea3e01f1712af2ca14d5b6a37d2e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (542cead) will **decrease** coverage by `0.00%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-kyuubi/pull/1513/graphs/tree.svg?width=650&height=150&src=pr&token=925D4tb9AH&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-kyuubi/pull/1513?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1513      +/-   ##
   ============================================
   - Coverage     59.38%   59.37%   -0.01%     
     Complexity      172      172              
   ============================================
     Files           238      238              
     Lines         12168    12168              
     Branches       1491     1491              
   ============================================
   - Hits           7226     7225       -1     
     Misses         4331     4331              
   - Partials        611      612       +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1513?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...ache/kyuubi/operation/KyuubiOperationManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1513/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9vcGVyYXRpb24vS3l1dWJpT3BlcmF0aW9uTWFuYWdlci5zY2FsYQ==) | `81.57% <0.00%> (-2.64%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1513?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1513?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [542cead...6e7d7f0](https://codecov.io/gh/apache/incubator-kyuubi/pull/1513?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-kyuubi] ulysses-you commented on pull request #1513: Added support liveness and readiness for kyuubi pod

Posted by GitBox <gi...@apache.org>.
ulysses-you commented on pull request #1513:
URL: https://github.com/apache/incubator-kyuubi/pull/1513#issuecomment-987484866


   thanks, merging to master


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-kyuubi] murong00 commented on a change in pull request #1513: Added support liveness and readiness for kyuubi pod

Posted by GitBox <gi...@apache.org>.
murong00 commented on a change in pull request #1513:
URL: https://github.com/apache/incubator-kyuubi/pull/1513#discussion_r762971628



##########
File path: docker/helm/values.yaml
##########
@@ -28,6 +28,18 @@ image:
   # Overrides the image tag whose default is the chart appVersion.
   tag: "master-snapshot"
 
+probe:
+  liveness:
+    enabled: true
+    failureThreshold: 10
+    initialDelaySeconds: 30
+    periodSeconds: 10
+  readiness:
+    enabled: true
+    failureThreshold: 10
+    initialDelaySeconds: 30
+    periodSeconds: 10

Review comment:
       @ulysses-you Done, thanks.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-kyuubi] ulysses-you closed pull request #1513: Added support liveness and readiness for kyuubi pod

Posted by GitBox <gi...@apache.org>.
ulysses-you closed pull request #1513:
URL: https://github.com/apache/incubator-kyuubi/pull/1513


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-kyuubi] ulysses-you commented on a change in pull request #1513: Added support liveness and readiness for kyuubi pod

Posted by GitBox <gi...@apache.org>.
ulysses-you commented on a change in pull request #1513:
URL: https://github.com/apache/incubator-kyuubi/pull/1513#discussion_r762953854



##########
File path: docker/helm/values.yaml
##########
@@ -28,6 +28,18 @@ image:
   # Overrides the image tag whose default is the chart appVersion.
   tag: "master-snapshot"
 
+probe:
+  liveness:
+    enabled: true
+    failureThreshold: 10
+    initialDelaySeconds: 30
+    periodSeconds: 10
+  readiness:
+    enabled: true
+    failureThreshold: 10
+    initialDelaySeconds: 30
+    periodSeconds: 10

Review comment:
       can we keep the same ordering with `kyuubi-depolyment.yaml` ?
   ```
   initialDelaySeconds
   periodSeconds
   failureThreshold
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-kyuubi] yaooqinn commented on pull request #1513: Added support liveness and readiness for kyuubi pod

Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #1513:
URL: https://github.com/apache/incubator-kyuubi/pull/1513#issuecomment-986639756


   cc @ulysses-you @hddong 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org