You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by Mark Martinec <Ma...@ijs.si> on 2008/02/08 00:47:11 UTC
A question on rulesrc/sandbox/
Are the rulesrc/sandbox/* directories shared across SVN branches?
Having added my sandbox under spamassassin-trunk, it is now
also seen under a spamassassin-3.2 branch. Which is fine,
as my rules (e.g. in 20_rpvalid.cf) are protected by
require_version 3.003000
...except that the RP_MATCHES_RCVD is propagated automatically
to rules/70_sandbox.cf as a T_RP_MATCHES_RCVD rule, but it loses
a protection of a 'require_version', so a 3.2 'make test' now
fails, bacause the rule uses an evaltest only available in 3.3.
Am I violating some protocol? I'm new to this, sorry if
it is my fault.
Mark
Re: A question on rulesrc/sandbox/
Posted by Mark Martinec <Ma...@ijs.si>.
> I gues the problem is in the code that copies rules from the sandboxes into
> the rules/70_sandbox.cf.
Thanks Justin for fixing mkrules.
Mark
Re: A question on rulesrc/sandbox/
Posted by Sidney Markowitz <si...@sidney.com>.
That's it. If I comment out the if (version >= ...) line and its endif in both of the
sandbox files that have them, then make completes with no errors.
I gues the problem is in the code that copies rules from the sandboxes into the
rules/70_sandbox.cf.
-- sidney
Re: A question on rulesrc/sandbox/
Posted by Sidney Markowitz <si...@sidney.com>.
Daryl C. W. O'Shea wrote, On 8/2/08 2:59 PM:
> Scratch that, the ifplugin lines are there. Is the checkout you're
> testing with not current and thus missing the updated version of the plugin?
I'm getting the same error in trunk. The ifplugin line is in the file in rulesrc, but is
not copied over into rules/70_sandbox.cf. Is it being confused by the nested ifplugins?
-- sidney
Re: A question on rulesrc/sandbox/
Posted by "Daryl C. W. O'Shea" <sp...@dostech.ca>.
Daryl C. W. O'Shea wrote:
> Mark Martinec wrote:
>> There seems to be something else wrong with my sandbox
>> and its interaction with 'make' (even though the standalone
>> .cf files seem to have linted just fine).
>>
>>
>> rules: failed to run RP_MATCHES_RCVD test, skipping:
>> (Can't locate object method "check_mailfrom_matches_rcvd" via
>> package "Mail::SpamAssassin::PerMsgStatus" at (eval 258) line 19.
>> )
>
> You're missing ifplugin lines for the WLBLEval plugin.
Scratch that, the ifplugin lines are there. Is the checkout you're
testing with not current and thus missing the updated version of the plugin?
Daryl
Re: A question on rulesrc/sandbox/
Posted by "Daryl C. W. O'Shea" <sp...@dostech.ca>.
Mark Martinec wrote:
> There seems to be something else wrong with my sandbox
> and its interaction with 'make' (even though the standalone
> .cf files seem to have linted just fine).
>
>
> rules: failed to run RP_MATCHES_RCVD test, skipping:
> (Can't locate object method "check_mailfrom_matches_rcvd" via
> package "Mail::SpamAssassin::PerMsgStatus" at (eval 258) line 19.
> )
You're missing ifplugin lines for the WLBLEval plugin.
Daryl
Re: A question on rulesrc/sandbox/
Posted by Mark Martinec <Ma...@ijs.si>.
On Friday 08 February 2008 01:31:49 Theo Van Dinter wrote:
> > require_version 3.003000
>
> use "if version >= 3.003000" instead
Great, that seems to solve it, thanks!
There seems to be something else wrong with my sandbox
and its interaction with 'make' (even though the standalone
.cf files seem to have linted just fine).
rules: failed to run RP_MATCHES_RCVD test, skipping:
(Can't locate object method "check_mailfrom_matches_rcvd" via
package "Mail::SpamAssassin::PerMsgStatus" at (eval 258) line 19.
)
lint: config: failed to parse line, skipping, in "rules/72_active.cf":
def_whitelist_from_dkim *@ebay.com at build/mkrules line 248.
...
but it will need to wait till tomorrow, or for someone else to figure out
what is going on.
Mark
Re: A question on rulesrc/sandbox/
Posted by Theo Van Dinter <fe...@apache.org>.
On Fri, Feb 08, 2008 at 12:47:11AM +0100, Mark Martinec wrote:
> Are the rulesrc/sandbox/* directories shared across SVN branches?
Yes.
> Having added my sandbox under spamassassin-trunk, it is now
> also seen under a spamassassin-3.2 branch. Which is fine,
> as my rules (e.g. in 20_rpvalid.cf) are protected by
> require_version 3.003000
use "if version >= 3.003000" instead
--
Randomly Selected Tagline:
"Now please floppy from your first drive and insert the boot floppy."
- Red Hat Installation for Linux
Re: A question on rulesrc/sandbox/
Posted by "Daryl C. W. O'Shea" <sp...@dostech.ca>.
Mark Martinec wrote:
> Are the rulesrc/sandbox/* directories shared across SVN branches?
Yeah (for 3.2 anyway) via an SVN external.
> Having added my sandbox under spamassassin-trunk, it is now
> also seen under a spamassassin-3.2 branch. Which is fine,
> as my rules (e.g. in 20_rpvalid.cf) are protected by
> require_version 3.003000
>
> ...except that the RP_MATCHES_RCVD is propagated automatically
> to rules/70_sandbox.cf as a T_RP_MATCHES_RCVD rule, but it loses
> a protection of a 'require_version', so a 3.2 'make test' now
> fails, bacause the rule uses an evaltest only available in 3.3.
That's a bug in mkrules (or elsewhere) that should be fixed. Can you
please open a bug about it with a note about what SVN revision to
reproduce it with.
> Am I violating some protocol? I'm new to this, sorry if
> it is my fault.
Nah, don't worry. The whole rules structure is in flux and is a mess.
Daryl