You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "jono-morris (via GitHub)" <gi...@apache.org> on 2023/10/23 11:24:39 UTC
[PR] Camel 15211 ssl context params configuration [camel]
jono-morris opened a new pull request, #11812:
URL: https://github.com/apache/camel/pull/11812
Added `camel.main.ssl.` parameters allowing Camel's SSL security parameters to be configured.
Tests added to camel-jetty, camel-netty, and camel-vertx.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Camel-15211: add props to configure SSL context parameters [camel]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus merged PR #11812:
URL: https://github.com/apache/camel/pull/11812
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Camel-15211: add props to configure SSL context parameters [camel]
Posted by "jono-morris (via GitHub)" <gi...@apache.org>.
jono-morris commented on PR #11812:
URL: https://github.com/apache/camel/pull/11812#issuecomment-1780953617
Added camel.main.ssl.xxx, and updated PrepareCamelMainMojo and BaseMainSupport.
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Camel-15211: add props to configure SSL context parameters [camel]
Posted by "jono-morris (via GitHub)" <gi...@apache.org>.
jono-morris commented on code in PR #11812:
URL: https://github.com/apache/camel/pull/11812#discussion_r1373022595
##########
core/camel-main/src/main/java/org/apache/camel/main/DefaultConfigurationProperties.java:
##########
@@ -159,6 +159,15 @@ public abstract class DefaultConfigurationProperties<T> {
private String startupRecorderProfile = "default";
private long startupRecorderDuration;
private String startupRecorderDir;
+ private boolean sslEnabled;
+ private String sslKeyStore;
+ @Metadata(defaultValue = "changeit")
+ private String sslKeystorePassword = "changeit";
Review Comment:
I've moved these default passwords.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Camel-15211 ssl context params configuration [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #11812:
URL: https://github.com/apache/camel/pull/11812#issuecomment-1774982525
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:robot: CI automation will test this PR automatically.
:camel: Apache Camel Committers, please review the following items:
* First-time contributors **require MANUAL approval** for the GitHub Actions to run
* You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot.
* You can label PRs using `build-all`, `build-dependents`, `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR.
* Build and test logs are available in the Summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary.
* :warning: Be careful when sharing logs. Review their contents before sharing them publicly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Camel-15211: add props to configure SSL context parameters [camel]
Posted by "jono-morris (via GitHub)" <gi...@apache.org>.
jono-morris commented on PR #11812:
URL: https://github.com/apache/camel/pull/11812#issuecomment-1782657382
Changes committed changing `camel.main.ssl` to `camel.ssl`. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Camel-15211: add props to configure SSL context parameters [camel]
Posted by "jono-morris (via GitHub)" <gi...@apache.org>.
jono-morris commented on PR #11812:
URL: https://github.com/apache/camel/pull/11812#issuecomment-1782791822
Yes certainly, let me take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Camel-15211: add props to configure SSL context parameters [camel]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on code in PR #11812:
URL: https://github.com/apache/camel/pull/11812#discussion_r1368586564
##########
core/camel-main/src/main/java/org/apache/camel/main/DefaultConfigurationProperties.java:
##########
@@ -159,6 +159,15 @@ public abstract class DefaultConfigurationProperties<T> {
private String startupRecorderProfile = "default";
private long startupRecorderDuration;
private String startupRecorderDir;
+ private boolean sslEnabled;
+ private String sslKeyStore;
+ @Metadata(defaultValue = "changeit")
+ private String sslKeystorePassword = "changeit";
Review Comment:
We should not have default passwords
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Camel-15211: add props to configure SSL context parameters [camel]
Posted by "jono-morris (via GitHub)" <gi...@apache.org>.
jono-morris commented on PR #11812:
URL: https://github.com/apache/camel/pull/11812#issuecomment-1781059982
Yes of course. Let me do that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Camel-15211: add props to configure SSL context parameters [camel]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #11812:
URL: https://github.com/apache/camel/pull/11812#issuecomment-1780978851
Can we change `camel.main.ssl` to `camel.ssl` as this is not tied to main only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Camel-15211: add props to configure SSL context parameters [camel]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #11812:
URL: https://github.com/apache/camel/pull/11812#issuecomment-1782720150
We also need some work for camel-spring-boot, to make camel.ssl configuration possible via its auto configuration.
Its something like threadpool but not exactly the same, but you can take a look
https://github.com/apache/camel-spring-boot/tree/main/core/camel-spring-boot/src/main/java/org/apache/camel/spring/boot/threadpool
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Camel-15211: add props to configure SSL context parameters [camel]
Posted by "jono-morris (via GitHub)" <gi...@apache.org>.
jono-morris commented on PR #11812:
URL: https://github.com/apache/camel/pull/11812#issuecomment-1777081026
Thanks for the review. Give me a day to make the changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org