You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@sling.apache.org by GitBox <gi...@apache.org> on 2020/10/19 14:49:22 UTC

[GitHub] [sling-org-apache-sling-models-impl] cjelger edited a comment on pull request #21: SLING-9834 - [Sling Models] Caching bug with reused Servlet requests

cjelger edited a comment on pull request #21:
URL: https://github.com/apache/sling-org-apache-sling-models-impl/pull/21#issuecomment-712216861


   @cziegeler @raducotescu I included your PR feedback: keep one single method to get or create the cache, and `synchronized` it on the adaptable to make sure we don't get any race condition. However SunarQube complains about the `synchronized` block because it's done on a method parameter, although here we exactly want to synchronize that block **_per_** adaptable and it's declared `final`. Not sure if this is a strict check and I should fix or not. WDYT?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org