[GitHub] [superset] rusackas commented on a change in pull request #15489: feat(explore): Examples image gallery in the viz type control

[GitBox <gi...@apache.org>]

rusackas commented on a change in pull request #15489:
URL: https://github.com/apache/superset/pull/15489#discussion_r662599659



##########
File path: superset-frontend/src/explore/components/controls/VizTypeControl/index.tsx
##########
@@ -223,20 +225,40 @@ const DetailsPane = styled.div`
   border-top: 1px solid ${({ theme }) => theme.colors.grayscale.light2};
   padding: ${({ theme }) => theme.gridUnit * 4}px;
   display: grid;
+  grid-template-columns: 1fr 1fr;
   grid-template-rows: auto 1fr;
-  overflow: hidden;
+  grid-template-areas:
+    'viz-name examples-header'
+    'description examples';
 `;
 
 // overflow hidden on the details pane and overflow auto on the description
 // (plus grid layout) enables the description to scroll while the header stays in place.
 
 const Description = styled.p`
+  grid-area: description;
+  overflow: auto;
+  padding-right: ${({ theme }) => theme.gridUnit * 14}px;

Review comment:
       Might also be able to just use `column-gap` here?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org