You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2023/01/06 21:51:55 UTC
[GitHub] [activemq] maxfortun opened a new pull request, #950: Feature/scheduler activity via joblistener
maxfortun opened a new pull request, #950:
URL: https://github.com/apache/activemq/pull/950
[AMQ-9188](https://issues.apache.org/jira/browse/AMQ-9188)
Alternative implementation based on discussion with @mattrpav in #949
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq] maxfortun commented on pull request #950: Feature/scheduler activity via joblistener
Posted by GitBox <gi...@apache.org>.
maxfortun commented on PR #950:
URL: https://github.com/apache/activemq/pull/950#issuecomment-1381020426
@mattrpav, as per our conversation in #949, reworked JobListener to have the following lifecycle hooks. Thoughts?
Ended up refactoring `memory`, `kahadb`, and tests.
1. willScheduleJob
2. scheduleJob
3. didScheduleJob
4. willDispatchJob
5. dispatchJob
6. didDispatchJob
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq] maxfortun commented on pull request #950: Feature/scheduler activity via joblistener
Posted by "maxfortun (via GitHub)" <gi...@apache.org>.
maxfortun commented on PR #950:
URL: https://github.com/apache/activemq/pull/950#issuecomment-1511991422
@mattrpav ping?:) I know you are swamped. Still hoping for a review :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq] maxfortun commented on pull request #950: Feature/scheduler activity via joblistener
Posted by "maxfortun (via GitHub)" <gi...@apache.org>.
maxfortun commented on PR #950:
URL: https://github.com/apache/activemq/pull/950#issuecomment-1411090680
@mattrpav Ping?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq] maxfortun commented on pull request #950: Feature/scheduler activity via joblistener
Posted by "maxfortun (via GitHub)" <gi...@apache.org>.
maxfortun commented on PR #950:
URL: https://github.com/apache/activemq/pull/950#issuecomment-1601568886
Found a way to achieve the same functionality without the need to modify the broker:
https://github.com/maxfortun/activemq-scheduler-store-advisory
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq] maxfortun closed pull request #950: Feature/scheduler activity via joblistener
Posted by "maxfortun (via GitHub)" <gi...@apache.org>.
maxfortun closed pull request #950: Feature/scheduler activity via joblistener
URL: https://github.com/apache/activemq/pull/950
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq] maxfortun commented on pull request #950: Feature/scheduler activity via joblistener
Posted by GitBox <gi...@apache.org>.
maxfortun commented on PR #950:
URL: https://github.com/apache/activemq/pull/950#issuecomment-1374176949
@mattrpav Is this approach more along the lines of what you had in mind?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org