You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2025/05/04 18:22:48 UTC
(commons-vfs) 02/02: Use try-with-resources
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-vfs.git
commit 8bb27447028af4cf00c399a5a153c15cb74b8de6
Author: Gary D. Gregory <ga...@gmail.com>
AuthorDate: Sun May 4 14:22:42 2025 -0400
Use try-with-resources
---
.../commons/vfs2/impl/DefaultFileMonitorTest.java | 39 ++++++++++------------
1 file changed, 18 insertions(+), 21 deletions(-)
diff --git a/commons-vfs2/src/test/java/org/apache/commons/vfs2/impl/DefaultFileMonitorTest.java b/commons-vfs2/src/test/java/org/apache/commons/vfs2/impl/DefaultFileMonitorTest.java
index e82a0fce6..c092f36b9 100644
--- a/commons-vfs2/src/test/java/org/apache/commons/vfs2/impl/DefaultFileMonitorTest.java
+++ b/commons-vfs2/src/test/java/org/apache/commons/vfs2/impl/DefaultFileMonitorTest.java
@@ -229,20 +229,18 @@ public class DefaultFileMonitorTest {
@Test
public void testFileMonitorRestarted() throws Exception {
- try (FileObject fileObject = fileSystemManager.resolveFile(testFile.toURI().toString())) {
- final DefaultFileMonitor monitor = new DefaultFileMonitor(new TestFileListener());
+ try (FileObject fileObject = fileSystemManager.resolveFile(testFile.toURI().toString());
+ DefaultFileMonitor monitor = new DefaultFileMonitor(new TestFileListener())) {
try {
// TestFileListener manipulates status
monitor.setDelay(DELAY_MILLIS);
monitor.addFile(fileObject);
-
monitor.start();
writeToFile(testFile);
Thread.sleep(DELAY_MILLIS * 5);
} finally {
monitor.stop();
}
-
monitor.start();
try {
testFile.delete();
@@ -255,23 +253,22 @@ public class DefaultFileMonitorTest {
@Test
public void testFileRecreated() throws Exception {
- try (FileObject fileObject = fileSystemManager.resolveFile(testFile.toURI())) {
- try (DefaultFileMonitor monitor = new DefaultFileMonitor(new TestFileListener())) {
- // TestFileListener manipulates status
- monitor.setDelay(DELAY_MILLIS);
- monitor.addFile(fileObject);
- monitor.start();
- writeToFile(testFile);
- waitFor(Status.CREATED, DELAY_MILLIS * 10, PeekLocation.LAST);
- resetStatus();
- testFile.delete();
- waitFor(Status.DELETED, DELAY_MILLIS * 10, PeekLocation.LAST);
- resetStatus();
- Thread.sleep(DELAY_MILLIS * 5);
- monitor.addFile(fileObject);
- writeToFile(testFile);
- waitFor(Status.CREATED, DELAY_MILLIS * 10, PeekLocation.LAST);
- }
+ try (FileObject fileObject = fileSystemManager.resolveFile(testFile.toURI());
+ DefaultFileMonitor monitor = new DefaultFileMonitor(new TestFileListener())) {
+ // TestFileListener manipulates status
+ monitor.setDelay(DELAY_MILLIS);
+ monitor.addFile(fileObject);
+ monitor.start();
+ writeToFile(testFile);
+ waitFor(Status.CREATED, DELAY_MILLIS * 10, PeekLocation.LAST);
+ resetStatus();
+ testFile.delete();
+ waitFor(Status.DELETED, DELAY_MILLIS * 10, PeekLocation.LAST);
+ resetStatus();
+ Thread.sleep(DELAY_MILLIS * 5);
+ monitor.addFile(fileObject);
+ writeToFile(testFile);
+ waitFor(Status.CREATED, DELAY_MILLIS * 10, PeekLocation.LAST);
}
}