(texera) 01/01: test(frontend): add unit test coverage for formly-config validation-message formatters (#6601)

[gi...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

github-merge-queue[bot] pushed a commit to branch gh-readonly-queue/main/pr-6601-4bdbd1c51274b6fec2390b942717f410623eb388
in repository https://gitbox.apache.org/repos/asf/texera.git

commit 14c265cb912b75f69c461fe3c95744f0b3196e42
Author: Meng Wang <me...@uci.edu>
AuthorDate: Mon Jul 20 12:10:47 2026 -0700

    test(frontend): add unit test coverage for formly-config validation-message formatters (#6601)
    
    ### What changes were proposed in this PR?
    
    Adds a spec for the ten pure validation-message formatters exported by
    `frontend/src/app/common/formly/formly-config.ts` (previously ~62%
    coverage,
    none of them tested). They are plain `(err, field) => string` functions,
    so the
    spec needs no TestBed.
    
    11 tests cover:
    
    - `minItemsValidationMessage` / `maxItemsValidationMessage` /
    `minlengthValidationMessage` / `maxlengthValidationMessage` /
    `minValidationMessage` / `maxValidationMessage` /
    `multipleOfValidationMessage` / `exclusiveMinimumValidationMessage` /
    `exclusiveMaximumValidationMessage` / `constValidationMessage` — each
    asserts the exact string produced from a sample `field.props`.
    - One case where the referenced `field.props` value is absent, so the
    optional-chaining branch (`field.props?.<x>` → `undefined` interpolated)
    is covered.
    
    No production code was changed.
    
    ### Any related issues, documentation, discussions?
    
    Closes #6591
    
    ### How was this PR tested?
    
    New unit tests, run locally in `frontend/` (all green; the failure path
    was
    verified by deliberately breaking an assertion to confirm the suite goes
    red):
    
    ```
    ng test --watch=false --include src/app/common/formly/formly-config.spec.ts
    # Test Files 1 passed (1) | Tests 11 passed (11)
    prettier --write <spec>   # unchanged
    eslint  <spec>            # clean
    ```
    
    The formatters are pure functions, so the suite is fully deterministic.
    
    ### Was this PR authored or co-authored using generative AI tooling?
    
    Generated-by: Claude Code (Opus 4.8 [1M context])
---
 .../src/app/common/formly/formly-config.spec.ts    | 82 ++++++++++++++++++++++
 1 file changed, 82 insertions(+)

diff --git a/frontend/src/app/common/formly/formly-config.spec.ts b/frontend/src/app/common/formly/formly-config.spec.ts
new file mode 100644
index 0000000000..d514fe6f17
--- /dev/null
+++ b/frontend/src/app/common/formly/formly-config.spec.ts
@@ -0,0 +1,82 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import { FormlyFieldConfig } from "@ngx-formly/core";
+import {
+  constValidationMessage,
+  exclusiveMaximumValidationMessage,
+  exclusiveMinimumValidationMessage,
+  maxItemsValidationMessage,
+  maxlengthValidationMessage,
+  maxValidationMessage,
+  minItemsValidationMessage,
+  minlengthValidationMessage,
+  minValidationMessage,
+  multipleOfValidationMessage,
+} from "./formly-config";
+
+// The formatters ignore their first (error) argument and read only field.props.
+const err = {};
+const field = (props: Record<string, unknown>): FormlyFieldConfig => ({ props }) as FormlyFieldConfig;
+
+describe("formly-config validation-message formatters", () => {
+  it("minItemsValidationMessage reports the minimum item count", () => {
+    expect(minItemsValidationMessage(err, field({ minItems: 3 }))).toBe("should NOT have fewer than 3 items");
+  });
+
+  it("maxItemsValidationMessage reports the maximum item count", () => {
+    expect(maxItemsValidationMessage(err, field({ maxItems: 5 }))).toBe("should NOT have more than 5 items");
+  });
+
+  it("minlengthValidationMessage reports the minimum length", () => {
+    expect(minlengthValidationMessage(err, field({ minLength: 2 }))).toBe("should NOT be shorter than 2 characters");
+  });
+
+  it("maxlengthValidationMessage reports the maximum length", () => {
+    expect(maxlengthValidationMessage(err, field({ maxLength: 10 }))).toBe("should NOT be longer than 10 characters");
+  });
+
+  it("minValidationMessage reports the inclusive minimum", () => {
+    expect(minValidationMessage(err, field({ min: 0 }))).toBe("should be >= 0");
+  });
+
+  it("maxValidationMessage reports the inclusive maximum", () => {
+    expect(maxValidationMessage(err, field({ max: 100 }))).toBe("should be <= 100");
+  });
+
+  it("multipleOfValidationMessage reports the step", () => {
+    expect(multipleOfValidationMessage(err, field({ step: 4 }))).toBe("should be multiple of 4");
+  });
+
+  it("exclusiveMinimumValidationMessage reports the exclusive minimum", () => {
+    expect(exclusiveMinimumValidationMessage(err, field({ exclusiveMinimum: 1 }))).toBe("should be > 1");
+  });
+
+  it("exclusiveMaximumValidationMessage reports the exclusive maximum", () => {
+    expect(exclusiveMaximumValidationMessage(err, field({ exclusiveMaximum: 9 }))).toBe("should be < 9");
+  });
+
+  it("constValidationMessage reports the required constant", () => {
+    expect(constValidationMessage(err, field({ const: "foo" }))).toBe('should be equal to constant "foo"');
+  });
+
+  it("interpolates undefined when the referenced prop is absent (optional-chaining branch)", () => {
+    expect(minItemsValidationMessage(err, {} as FormlyFieldConfig)).toBe("should NOT have fewer than undefined items");
+  });
+});