You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/04/13 08:27:11 UTC
[GitHub] [incubator-nuttx] no1wudi opened a new pull request, #6059: arch/risc-v/riscv_misaligned: Correct sw source register
no1wudi opened a new pull request, #6059:
URL: https://github.com/apache/incubator-nuttx/pull/6059
## Summary
If source register of sw instruction is x0, we must point it to a constant zero
since in NuttX's context, value of index 0 is EPC.
## Impact
misaligned handler
## Testing
K210/BL602
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #6059: arch/risc-v/riscv_misaligned: Correct sw source register
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged PR #6059:
URL: https://github.com/apache/incubator-nuttx/pull/6059
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6059: arch/risc-v/riscv_misaligned: Correct sw source register
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #6059:
URL: https://github.com/apache/incubator-nuttx/pull/6059#discussion_r849227448
##########
arch/risc-v/src/common/riscv_misaligned.c:
##########
@@ -363,6 +363,7 @@ static bool decode_insn_compressed(uintptr_t *regs, riscv_insn_ctx_t *ctx)
static bool decode_insn(uintptr_t *regs, riscv_insn_ctx_t *ctx)
{
+ static const uintptr_t x0 = 0;
Review Comment:
```suggestion
static const uintptr_t x0;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] no1wudi commented on a diff in pull request #6059: arch/risc-v/riscv_misaligned: Correct sw source register
Posted by GitBox <gi...@apache.org>.
no1wudi commented on code in PR #6059:
URL: https://github.com/apache/incubator-nuttx/pull/6059#discussion_r849242486
##########
arch/risc-v/src/common/riscv_misaligned.c:
##########
@@ -363,6 +363,7 @@ static bool decode_insn_compressed(uintptr_t *regs, riscv_insn_ctx_t *ctx)
static bool decode_insn(uintptr_t *regs, riscv_insn_ctx_t *ctx)
{
+ static const uintptr_t x0 = 0;
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org