[GitHub] [iceberg] rdblue commented on a change in pull request #2275: Core: add schema id to snapshot

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #2275:
URL: https://github.com/apache/iceberg/pull/2275#discussion_r642697358



##########
File path: core/src/main/java/org/apache/iceberg/SerializableTable.java
##########
@@ -147,6 +147,7 @@ public String location() {
     return properties;
   }
 
+  // Note that schema parsed from string does not contain the correct schema ID.

Review comment:
       I think we should use the correct `toJson` implementation so that we don't need to note that the ID doesn't match.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org